add confirmation-spendability knob for bitcoind-rpc #367
Conversation
This addresses JoinMarket-Org#39 but does not solve it for blockr users. It modifies the default behavior of wallet-tool.py when using a full node to count unconfirmed balances, without spending them.
|
It occurred to me earlier today that what people want is for the wallet-tool to by default show both confirmed and unconfirmed amounts. At least, that's what I'd want. That's not to say that fine-grained control isn't nice, too. Edit: sorry, being dense, you do make the default to show unconfirmed. But I think we really want both in the output? |
|
Apart from that nit, utACK. |
|
W.r.t. https://github.com/JoinMarket-Org/joinmarket/pull/367/files#diff-c1c696807da8327197e6ee5f13c1389eR148 - I am wondering, apart from the malleation warning, whether it might not actually work to use unconfirmed (esp. if we consider counterparties not using this setting). Seems unobvious. I think the safest thing for now would be to say "don't do that". |
|
Tried on mainnet and confirmed functionality: with nothing specified in config, wallet-tool (working off Core interface) showed the unconfirmed coins. |
| # 1st value is the inclusive minimum, defaults to one confirmation | ||
| # 2nd value is the exclusive maximum, defaults to most-positive-bignum (Google Me!) | ||
| # leave it unset to defer to bitcoind's default values, ie [1, 9999999] | ||
| #listunspent = [] |
There was a problem hiding this comment.
shouldn't this line show #listunspent_args = [] ?
There was a problem hiding this comment.
Thank you, I'll fix it.
add confirmation-spendability knob for bitcoind-rpc
This addresses #39 but does not solve it for blockr users.
When using a full node,
wallet-tool.pywill display unconfirmed balances by default, but other scripts won't actually spend them unless that behavior is manually configured.