-
Notifications
You must be signed in to change notification settings - Fork 119
Add unconfirmed coins to output from wallet-tool #39
Comments
This seems To be A blockr issue, I don't think they count unconfirmed by default, they're hostile |
Including unconfirmed (zero confirmation) transactions. Adding an optional parameter unconfirmed=1 to unspent API, the API searches and returns unspent transactions also among transactions that are not yet part of the blocks (unconfirmed transactions). |
yes, the blockr.io API supports checking for unconfirmed transactions. If you're planning to program this up and submit a pull request, be aware that makers should not send unconfirmed transactions are UTXO inputs. |
Note that this requires somewhat redesigning the Wallet class |
If we ever do this, be mindful of transaction malleability. See this thread for the havoc caused by poorly written handling of unconfirmed txes https://www.reddit.com/r/Bitcoin/comments/3nfb2y/eli5_for_double_spends_bitcoin_being_sent_twice/ |
This addresses JoinMarket-Org#39 but does not solve it for blockr users. It modifies the default behavior of wallet-tool.py when using a full node to count unconfirmed balances, without spending them.
(low priority but worth doing at some point)
The text was updated successfully, but these errors were encountered: