Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Add unconfirmed coins to output from wallet-tool #39

Open
AdamISZ opened this issue Feb 5, 2015 · 5 comments
Open

Add unconfirmed coins to output from wallet-tool #39

AdamISZ opened this issue Feb 5, 2015 · 5 comments

Comments

@AdamISZ
Copy link
Member

AdamISZ commented Feb 5, 2015

(low priority but worth doing at some point)

@BitPopCoin
Copy link

This seems To be A blockr issue, I don't think they count unconfirmed by default, they're hostile

@BitPopCoin
Copy link

Including unconfirmed (zero confirmation) transactions.

Adding an optional parameter unconfirmed=1 to unspent API, the API searches and returns unspent transactions also among transactions that are not yet part of the blocks (unconfirmed transactions).
Whenever unconfirmed=1 is used a new field "with_unconfirmed": true is added to the response to let developers know there are unsafe (unconfirmed) transactions in the output.
http://btc.blockr.io/api/v1/address/unspent/198aMn6ZYAczwrE5NvNTUMyJ5qkfy4g3Hi?unconfirmed=1

@chris-belcher
Copy link
Collaborator

yes, the blockr.io API supports checking for unconfirmed transactions.
It's also quite easy to use Bitcoin Core json-rpc for unconfirmed transactions.
I'm also keen to use insight API as in #64 for further decentralization.

If you're planning to program this up and submit a pull request, be aware that makers should not send unconfirmed transactions are UTXO inputs.

@chris-belcher
Copy link
Collaborator

Note that this requires somewhat redesigning the Wallet class

@chris-belcher
Copy link
Collaborator

If we ever do this, be mindful of transaction malleability. See this thread for the havoc caused by poorly written handling of unconfirmed txes https://www.reddit.com/r/Bitcoin/comments/3nfb2y/eli5_for_double_spends_bitcoin_being_sent_twice/

adlai added a commit to adlai/joinmarket that referenced this issue Dec 16, 2015
This addresses JoinMarket-Org#39 but does not solve it for blockr users.

It modifies the default behavior of wallet-tool.py when using a
full node to count unconfirmed balances, without spending them.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants