-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tx_broadcast set to "not-self" does not work #368
Comments
Sorry I was busying addressing two other issues yesterday so didn't pay attention to this, but see: It's been discussed a few times, I thought you knew (my mistake, I can't assume everyone just knows everything that gets discussed) basically it's one of a number of things I was hoping would get fixed up later. |
Currently, only 'self' works until the other options for tx_broadcast are implemented. Update the docs accordingly, because there was someone wondering on IRC today why his transaction failed to broadcast; the reason was he changed this setting, which currently only works for 'self'. If the other options are implemented (tagging JoinMarket-Org#368 ), this documentation should be changed along with it.
I added the label "bug" because it really is a bug that this setting exists but is not implemented (even if we fixed a crash from it). The context matters; this feature existed in the old version and was always intended in the new version, but was never done. There is a reason why it's a little more than trivial, otherwise I would have done it at the start. So it's a bug but it's also an enhancement :) |
Fixed a bug already in #365 , but even with this fix, the TX does not get broadcast. @kristapsk noticed the same, see the #365 .
Just writing this down here so this is not forgotten:
So far, tested on mainnet:
Taker does send the push command to a maker according to logs. That command never is seen on the maker side, at least there is no log entry whatsoever about this private message from the taker.
This is the taker side:
The text was updated successfully, but these errors were encountered: