Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx_broadcast set to "not-self" does not work #368

Closed
AlexCato opened this issue Jul 9, 2019 · 2 comments
Closed

tx_broadcast set to "not-self" does not work #368

AlexCato opened this issue Jul 9, 2019 · 2 comments

Comments

@AlexCato
Copy link
Contributor

AlexCato commented Jul 9, 2019

Fixed a bug already in #365 , but even with this fix, the TX does not get broadcast. @kristapsk noticed the same, see the #365 .

Just writing this down here so this is not forgotten:

So far, tested on mainnet:
Taker does send the push command to a maker according to logs. That command never is seen on the maker side, at least there is no log entry whatsoever about this private message from the taker.

This is the taker side:

2019-07-08 15:42:15,231 [DEBUG]  Created watcher loop for txid: <TXID>
2019-07-08 15:42:15,240 [DEBUG]  >>privmsg on DarkScience: nick=<MAKERNAME> cmd=push msg=<SUPERLONG_STRING>
2019-07-08 15:44:18,243 [INFO]  Abandoning monitoring of un-broadcast tx for: <TXID>
2019-07-08 15:48:05,142 [INFO]  STALL MONITOR:
2019-07-08 15:48:05,142 [INFO]  Tx was already pushed; ignoring
@AdamISZ
Copy link
Member

AdamISZ commented Jul 9, 2019

Sorry I was busying addressing two other issues yesterday so didn't pay attention to this, but see:

https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmdaemon/jmdaemon/daemon_protocol.py#L449

It's been discussed a few times, I thought you knew (my mistake, I can't assume everyone just knows everything that gets discussed) basically it's one of a number of things I was hoping would get fixed up later.

AlexCato added a commit to AlexCato/joinmarket-clientserver that referenced this issue Jul 12, 2019
Currently, only 'self' works until the other options for tx_broadcast are implemented. Update the docs accordingly, because there was someone wondering on IRC today why his transaction failed to broadcast; the reason was he changed this setting, which currently only works for 'self'.

If the other options are implemented (tagging JoinMarket-Org#368 ), this documentation should be changed along with it.
@AdamISZ AdamISZ added the bug label Jul 26, 2019
@AdamISZ
Copy link
Member

AdamISZ commented Jul 26, 2019

I added the label "bug" because it really is a bug that this setting exists but is not implemented (even if we fixed a crash from it). The context matters; this feature existed in the old version and was always intended in the new version, but was never done. There is a reason why it's a little more than trivial, otherwise I would have done it at the start. So it's a bug but it's also an enhancement :)

@AdamISZ AdamISZ mentioned this issue Aug 27, 2020
AdamISZ added a commit that referenced this issue Sep 14, 2020
4440ffb Taker broadcasts tx after unconfirm_timeout_sec. (Adam Gibson)
d209d4d Fixes #368. random-peer and not-self tx broadcast. (Adam Gibson)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants