Add crossorigin link attribute #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnSundell
reviewed
Mar 31, 2023
There was a problem hiding this comment.
Thanks a lot for this @davidrothera, and I'm very sorry for taking so long to review your PR! I've left a suggestion inline, otherwise I think this looks fantastic.
JohnSundell
added
the
awaiting update
As per review comments on JohnSundell#87
|
Amended with changes as per your suggestion @JohnSundell 👍 |
JohnSundell
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Thanks a lot for updating your PR, @davidrothera! It looks fantastic now - I just did some minor edits to rename the boolean parameter to isEnabled and added parameter docs. Ready to merge in now 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crossorigin attribute is needed for things like Google fonts where you should link to it like below:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link#attributes
At the moment doing this means manually creating an
Attributeinstance but this would be cleaner.