Change crossorigin to take a bool argument

As per review comments on #87
JohnSundell · Apr 3, 2023 · 64d234a · 64d234a
1 parent bb1b9bf
commit 64d234a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/Sources/Plot/API/HTMLAttributes.swift b/Sources/Plot/API/HTMLAttributes.swift
@@ -180,8 +180,8 @@ public extension Attribute where Context == HTML.LinkContext {
     }
 
     /// Assign a `crossorigin` attribute to the link.
-    static func crossorigin() -> Attribute {
-        Attribute(name: "crossorigin", value: nil, ignoreIfValueIsEmpty: false)
+    static func crossorigin(_ crossOrigin: Bool) -> Attribute {
+        crossOrigin ? Attribute(name: "crossorigin", value: nil, ignoreIfValueIsEmpty: false) : .empty
     }
 }
 

diff --git a/Tests/PlotTests/HTMLTests.swift b/Tests/PlotTests/HTMLTests.swift
@@ -174,18 +174,30 @@ final class HTMLTests: XCTestCase {
         """)
     }
 
-    func testCrossoriginLink() {
+    func testCrossoriginLinkEnabled() {
         let html = HTML(.head(.link(
             .rel(.preconnect),
             .href("https://foo.com"),
-            .crossorigin()
+            .crossorigin(true)
         )))
 
         assertEqualHTMLContent(html, """
         <head><link rel="preconnect" href="https://foo.com" crossorigin/></head>
         """)
     }
 
+    func testCrossoriginLinkDisabled() {
+        let html = HTML(.head(.link(
+            .rel(.preconnect),
+            .href("https://foo.com"),
+            .crossorigin(false)
+        )))
+
+        assertEqualHTMLContent(html, """
+        <head><link rel="preconnect" href="https://foo.com"/></head>
+        """)
+    }
+
     func testManifestLink() {
         let html = HTML(.head(.link(
             .rel(.manifest),