IE-fix: don't blur if document.activeElement is menuDOM #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to merge this and get the fix out quickly, then circle back for the test. @bruderstein might have an idea on how to approach it. |
JedWatson
added a commit
that referenced
this pull request
Oct 27, 2015
IE-fix: don't blur if document.activeElement is menuDOM
|
Thanks for this fix, by the way! |
|
Cool 👍 |
This was referenced Dec 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495.
Still missing a test though: took multiple different stabs to simulate the situation #495 creates when the scrollbar is clicked (
menuDOMis thedocument.activeElement) in a testable fashion, but couldn't find anything (at least yet) that would actually test that behavior.Any ideas for the test? The other tests pass just fine.