Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE10/11: Menu closes when trying click+drag scroll indicator #495

Closed
rethwyll opened this issue Oct 2, 2015 · 7 comments
Closed

IE10/11: Menu closes when trying click+drag scroll indicator #495

rethwyll opened this issue Oct 2, 2015 · 7 comments

Comments

@rethwyll
Copy link

rethwyll commented Oct 2, 2015

In IE10 (Win8) and IE11 (Win8.1), when you try to click and drag the scroll indicator in the dropdown menu, the menu closes instead of scrolling. This behavior can be observed on the live demo page (http://jedwatson.github.io/react-select/) with the very first example, the "States" select.

@songz
Copy link

songz commented Oct 9, 2015

Ping. I am having this issue as well.

@petetnt
Copy link
Contributor

petetnt commented Oct 14, 2015

Maybe not loosely enough* based on Selectize: selectize/selectize.js#182 🍔 😋

How it was fixed in Selectize: bigfox/selectize.js@0a75d45

Basically the Blur event occurs (causing handleInputBlur) to trigger when the scrollbar is clicked. This does not occur on other browsers. Investigating how to get around this ATM.

petetnt added a commit to petetnt/react-select that referenced this issue Oct 14, 2015
@petetnt
Copy link
Contributor

petetnt commented Oct 14, 2015

Okay, the fix is pretty trivial:

    handleInputBlur (event) {
        var menuDOM = ReactDOM.findDOMNode(this.refs.menu);
        if (document.activeElement.isEqualNode(menuDOM)) {
            return;
        }

        /**/

Working branch here: https://github.com/petetnt/react-select/tree/petetnt/ie10-11-blur-fix

It needs a test though. ping @JedWatson

@nil4
Copy link
Contributor

nil4 commented Oct 20, 2015

@petetnt: thank you, I can confirm your fix resolves this issue on IE 11.

@duoduoin
Copy link

@petetnt Thanks, this fixes the issue on IE9-IE11.
@JedWatson could you merge this fix and make a new release?

@petetnt
Copy link
Contributor

petetnt commented Oct 26, 2015

I'll create some tests for it and fix spaces to tabs and try to create a PR for this today or tomorrow

@JedWatson
Copy link
Owner

Thanks @petetnt 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants