Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete big paren commands: 'left(' -> '\left( ... \right)' #2397

Merged
merged 2 commits into from
Nov 27, 2020

Conversation

jlelong
Copy link
Collaborator

@jlelong jlelong commented Nov 26, 2020

This is a follow up on #2116 and #2394

The following commands get a unique autocompletion : (\\left|\\[Bb]ig{1,2}l|\\)[({[]

Nov-26-2020 15-52-34

Note that to insert \left\{ ... \right\}, you have to type \left{ without the \ before the {. This is because autocompletion considers that the command to complete starts at the last \ and we cannot change that.

Close #2112. I think this PR finally (and hopefully) solves all the auto-closing issue in autocompletion.

@jlelong jlelong requested a review from tamuratak November 26, 2020 14:57
@tamuratak
Copy link
Contributor

tamuratak commented Nov 27, 2020

  1. Type \le
  2. Enter Esc to close suggests.
  3. Enter Ctrl+Space to reopen suggests.

Suggests include only one entry:

Nov-27-2020 14-17-29

@jlelong
Copy link
Collaborator Author

jlelong commented Nov 27, 2020

The filtering was a little too aggressive. This is fixed.

@jlelong jlelong merged commit 18e80e3 into James-Yu:master Nov 27, 2020
@jlelong jlelong deleted the big-paren-completion branch November 27, 2020 08:45
jlelong added a commit that referenced this pull request Nov 27, 2020
It is related to
  -  Autocomplete big paren commands PR #2397
  - Fix #2061 indentation with begin/end on the same line.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

\left( does not match \left( ... \right) in suggestions.
2 participants