Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fix for double }} in completion #2394

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

jlelong
Copy link
Collaborator

@jlelong jlelong commented Nov 25, 2020

This commit basically reverts #2293 and #2080. Instead it uses the same approach as #2370.
The new approach is less intrusive and much cleaner.
@tamuratak can you test it?

@jlelong jlelong added the dev Development discussions label Nov 25, 2020
This commit basically reverts James-Yu#2293 and James-Yu#2080. Instead it uses the same
approach as James-Yu#2370.
@jlelong jlelong force-pushed the brace-autocompletion branch from c346832 to 142ff2d Compare November 25, 2020 17:23
@jlelong jlelong changed the title Refactor fix for double }} in begin completion Refactor fix for double }} in completion Nov 25, 2020
@tamuratak
Copy link
Contributor

The issue #2075 occurs again.

Nov-26-2020 08-45-53

If you are saying that stopping auto-closing with } for \begin{ is enough, I agree it is enough.

@jlelong
Copy link
Collaborator Author

jlelong commented Nov 26, 2020

#2075 was related to the auto-closing of {. With this PR, typing \begin{item and completing works fine

Nov-26-2020 09-32-03

However, it is true that completing \begin{item} fails

Nov-26-2020 09-33-05

But I cannot really see the purpose of such as completion. Instead,

Nov-26-2020 09-36-24

What could be done when completing \begin{item} with the cursor inside {} is to only complete the environment name and not to add the \end{} part.

Are you fine with this approach?

@tamuratak
Copy link
Contributor

Yes, I am fine with it.

Do not insert the \end part. This is related to James-Yu#2075 to avoid the
extra }
@jlelong jlelong merged commit e4c45fc into James-Yu:master Nov 26, 2020
@jlelong jlelong deleted the brace-autocompletion branch November 26, 2020 11:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dev Development discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants