feat(launcher): item.name as fallback for app icon #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeStanger
reviewed
Feb 26, 2024
Comment on lines
+169
to
+173
| let input = if item.app_id.is_empty() { | ||
| item.name.clone() | ||
| } else { | ||
| item.app_id.clone() | ||
| }; |
There was a problem hiding this comment.
Untested but I think you can reduce this to the following:
Suggested change
| let input = if item.app_id.is_empty() { | |
| item.name.clone() | |
| } else { | |
| item.app_id.clone() | |
| }; | |
| let input = let input = item.app_id.cloned().unwrap_or_else(|| item.app_id.clone()); |
Or you might be able to use .or_else, and use a single clone at the end
|
Cheers for the PR, seems like a good fix |
slowsage
commented
Feb 27, 2024
JakeStanger
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using spotify in wayland with hyprland, the spotify icon is not pulled up correctly by the launcher module:
spotify --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform=waylandThe class/app_id is "" while the name/title is "Spotify Premium". This uses item.name as a fallback which ensure spotify icon shows up correctly under wayland. Spotify under X11 does not have this problem.
Refs: #228, #146