Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focused and Launcher modules attempt to render unknown image types. #146

Closed
A-Cloud-Ninja opened this issue May 8, 2023 · 3 comments · Fixed by #154
Closed

Focused and Launcher modules attempt to render unknown image types. #146

A-Cloud-Ninja opened this issue May 8, 2023 · 3 comments · Fixed by #154
Labels
bug Something isn't working
Milestone
0.12.1

Comments

@A-Cloud-Ninja
Copy link
Contributor

Describe the bug
Possibly due to flatpak'd versions of Spotify and Discord (and otherwise icon-missing applications), apps that don't properly have an icon do not get verified, and an error is printed.
To Reproduce
Steps to reproduce the behavior:

  1. Use launcher or focused with show_icon
  2. Have an app that either doesn't have an icon or otherwise isn't in the correct location
  3. Launch ironbar, observe errors upon loading icons for the app.

Expected behavior
Either a warning and/or discarding or sanitizing of related items

System information:

  • Distro: Arch
  • Compositor: Hyprland
  • Ironbar version: Ironbar version 0.12.1 via ironbar --version on aur/ironbar-git

Configuration
https://f.cloudninja.pw/ironbar_config.json

Screenshot
SuccinctIncompetentKoala
@A-Cloud-Ninja A-Cloud-Ninja added the bug Something isn't working label May 8, 2023
@JakeStanger
Copy link
Owner

Will improve the error handling around this to try and rule out some of the non-errors, reduce missing images to warnings, and avoid printing the full stack.

@JakeStanger JakeStanger added this to the 0.12.1 milestone May 9, 2023
JakeStanger added a commit that referenced this issue May 20, 2023
@JakeStanger
fix: poor error handling for missing images
87ca399 
Previously images that could not be located were handled by throwing a
full report error, which incorrectly stated it was an invalid image
*type*.

This changes the image handling to instead log a single-line warning
directly in the image provider code, reducing the error handling
required by each consumer.

Resolves #146.
@JakeStanger JakeStanger mentioned this issue May 20, 2023
Merged
@TheSunCat
Copy link

When focusing an app for which it cannot find an icon (though Anyrun does find the icon), ironbar does indeed just print a warning, however it still renders the icon for the last focused app.

For example, if I move focus from Firefox to Supersonic (AUR package supersonic-desktop), ironbar fails to find Supersonic's icon and instead renders Firefox's icon.

@JakeStanger JakeStanger mentioned this issue May 28, 2023
Closed
@JakeStanger
Copy link
Owner

Thanks for reporting. I've opened an issue to track that and should get it sorted soon.

@slowsage slowsage mentioned this issue Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.12.1
Development

Successfully merging a pull request may close this issue.

fix: poor error handling for missing images JakeStanger/ironbar
3 participants
@JakeStanger @A-Cloud-Ninja @TheSunCat