Move the nearest item logic over to the PhysicsSystem
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackAshwell11
force-pushed
the
nearest_item_conversion
branch
2 times, most recently
from
3c601f3 to
9c63c28
Compare
…ity to get the nearest Chipmunk2D sensor to another game object (if they're within a minimum range). Implemented `Registry::get_game_object_type()` allowing for a client to get the stored game object type giving a game object ID. This allowed me to simplify `AttackSystem::do_attack()` since the previous change required passing in the game object type, but now we can get it from the registry. Fixed a Python typing error with the `KinematicComponent` constructor. Removed an unused header in `steering.cpp`.
…em::remove_item_from_inventory()`, and `InventorySystem::use_item()` allowing them to absorb more of the logic from `game.py`. Added `Registry::has_game_object()` allowing a client to easily check if a given game object ID is registered with the registry. Added a new event type `SpriteRemoval` which is called when a game object needs to be removed from an Arcade spritelist.
JackAshwell11
force-pushed
the
nearest_item_conversion
branch
from
9c63c28 to
5a7d53f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR refactors the
Gameview to take on a more high-level orchestrating role by thenearest_itemlogic into thePhysicsSystemremoving the equivalent Python code from theGameview. It also adds a few other quality of life changes such as two new functions to theRegistryand a new event type allowing future refactors to take place.Type of Changes
Tasks
PhysicsSystem::get_nearest_item().nearest_itemto allow them to work with this newer version.