-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #6601: Right click menu for main table header #7729
Conversation
finished updateContextMenu, languages needed
finished lang support
Puneet Fix right-click on Mac
…sing touchpad to right click
Fixed Bug: Added Code to hide the Right Click Menu for MAC OS- when using touchpad for right-click
Add visible status feature and couple getter and setter methods
Fix VisibleStatus and Code cleanup
Thanks, overall this looks already good! I'm just not that happy with the approach for the visible status. I need to think about a better approach. |
Perhaps use a |
Thanks, we'll take a look at reviewlog |
Right click menu is a good thing, but the visible property in this case not... Please remove the visible property handling here and try add/remove columns (maybe with a standard set of columns) in the list of main table columns. See TableTabViewModel. |
@sj30001 It would be really nice if you could add the required changes |
Thanks, I'll discuss with our team and apply changes as required |
…methods - getVisibleStatus() & setVisibleStatus(boolean visible)
Fixed Style Check Bug: Added extra space after method definition for …
Hi Calixtus, Another confusion we have is with the auto check, we've managed to fix the style check problem reported by auto-check, but there is a MacOS installer fail check we don't know why it didn't pass. We've used a Mac machine to build the run the project with no problem. Do we need to worry about that? Thanks a lot for reading this, it will be great if you could give us a little hint on what we should do. Thanks again. |
You can ignore the mac installer. It's not working on forks because it requires access to secrets for notarization. |
About the visibility property. Yes what you describe is from the user perspective the main problem: With your changes there are now two different ways to show/hide columns: By changing the columns in the preferences AND also by showing/hiding them in the right-click menu. This is confusing for the user, as the user expects only one place / one way to show and hide columns in the main table. So I would ask you, to show/hide the columns by adding or removing them from the columns list instead of changing the visibility property. Note that this is also in my opinion a question of performance, since hidden by visibility property columns are still computed. In a database with only about 100 entries, this may not make much difference, but in database of 10000 it does. In the right-click-menu there should only be a list with commonly used columns, that can be added or removed, maybe also the recently used columns. If you have questions I'm happy to help. Thank you for your efforts to make JabRef a better library management tool! |
Thanks, this clarifies our confusion. We'll make the necessary changes ASAP. Thanks again |
Hi, Thanks for the guidance.
|
A standard column list can be made up, yet we only have the default values in JabRefPreferences. But these are probably only too few. |
Closing this PR due to inactivity 💤 Please comment on the PR if you intend to continue to work on the PR. |
Fixes #6601
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)We've added right-click menu in JabRef main table header to achieved a show and hide function for different table columns. The right-click menu also gives the user a link to the preferences entry table.
Right Click menu:
Hide and show table columns:
Jump to preferences entry table:
Multi-language support:
Bug Fixed:
1.Fix right-click not working properly on Mac OS
2.Fix show and hide status being refreshed after preference saved