Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 7416: font size of the preferences dialog does not update with the rest of the GUI. #7509

Merged
merged 11 commits into from
Mar 27, 2021
Merged

Fix for issue 7416: font size of the preferences dialog does not update with the rest of the GUI. #7509

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4851e84
Merge pull request #1 from JabRef/master
XDZhelheim Mar 3, 2021
ae45307
Merge pull request #2 from JabRef/master
XDZhelheim Mar 8, 2021
b95ce43
Merge pull request #3 from JabRef/master
XDZhelheim Mar 9, 2021
fec81da
Fix #7416
XDZhelheim Mar 9, 2021
529551f
update CHANGELOG.md
XDZhelheim Mar 9, 2021
28db1f1
update CHANGELOG.md
XDZhelheim Mar 11, 2021
77f68a0
Merge branch 'master' into fix-for-issue-7416
XDZhelheim Mar 11, 2021
c902785
delete a blank line
XDZhelheim Mar 11, 2021
1092ec3
delete some whitespace
XDZhelheim Mar 11, 2021
9cb734c
delete some whitespace
XDZhelheim Mar 11, 2021
210cd21
Merge branch 'master' into fix-for-issue-7416
calixtus Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We fixed an issue where "Merge citations" in the Openoffice/Libreoffice integration panel did not have a corresponding opposite. [#7454](https://github.com/JabRef/jabref/issues/7454)
- We fixed an issue where drag and drop of bib files for opening resulted in uncaught exceptions [#7464](https://github.com/JabRef/jabref/issues/7464)
- We fixed an issue where Content selector does not seem to work for custom fields. [#6819](https://github.com/JabRef/jabref/issues/6819)
- We fixed an issue where font size of the preferences dialog does not update with the rest of the GUI. [#7416](https://github.com/JabRef/jabref/issues/7416)

### Removed

Expand Down
2 changes: 2 additions & 0 deletions src/main/java/org/jabref/gui/preferences/PreferencesDialogView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ public PreferencesDialogView(JabRefFrame frame) {

ControlHelper.setAction(saveButton, getDialogPane(), event -> savePreferencesAndCloseDialog());

this.getDialogPane().setStyle("-fx-font-size: " + preferencesService.getAppearancePreferences().getMainFontSize() + "pt;");

// ToDo: After conversion of all tabs to mvvm, rework interface and make validSettings bindable
// Button btnSave = (Button) this.getDialogPane().lookupButton(saveButton);
// btnSave.disableProperty().bind(viewModel.validSettings().validProperty().not());
Expand Down