Fix for issue 7416: font size of the preferences dialog does not update with the rest of the GUI. #7509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update 2021.3.3
update 2021.3.8
update 2021.3.9
Siedlerchr
approved these changes
Mar 9, 2021
Siedlerchr
added
the
status: ready-for-review
|
@XDZhelheim Thank you for the fix. I was unaware that I could use |
|
Thanks for your acknowledgement and notice! I made some mistakes on my IDE's auto-formatting, however, it seems there is no conflict now. |
|
I'm OK, take your time : ) |
calixtus
approved these changes
Mar 25, 2021
Siedlerchr
approved these changes
Mar 27, 2021
Siedlerchr
added a commit
that referenced
this pull request
Mar 28, 2021
* upstream/master: (191 commits) Fix for issue 7416: font size of the preferences dialog does not update with the rest of the GUI. (#7509) Fix school/instituation is printed twice (#7574) Dsiable notarisation until we hae an account for JabRef e.V. (#7572) Fix citation keys unintentionally being overwritten on import (#7443) Fix AuthentificationPlugin not declared in mergedModule (#7570) Suggestions for changes in caching latex free authors (#7301) Add simple Unit Tests (#7542) Fix drag and drop into empty library (#7555) Bump richtextfx from 0.10.4 to 0.10.6 (#7563) Bump pdfbox from 2.0.22 to 2.0.23 (#7561) Bump org.eclipse.jgit (#7560) Bump fontbox from 2.0.22 to 2.0.23 (#7562) Bump guava from 30.1-jre to 30.1.1-jre (#7564) Bump xmpbox from 2.0.22 to 2.0.23 (#7565) Bump hmarr/auto-approve-action from v2.0.0 to v2.1.0 (#7566) Add gource (#7193) UI: Fix for group icon (#7552) Fix for issue 6487: Opening BibTex file (doubleclick) from Folder with spaces not working (#7551) add ability to insert arxivId (#7549) Fixed missing trigger for linked file operations (#7548) ...
Siedlerchr
added a commit
that referenced
this pull request
Mar 29, 2021
* upstream/master: Bump classgraph from 4.8.102 to 4.8.104 (#7587) Bump checkstyle from 8.41 to 8.41.1 (#7586) Bump org.beryx.jlink from 2.23.3 to 2.23.5 (#7588) Revert "Re-add LibericaJDK" Re-add LibericaJDK Update gradle from 6.8 to 6.8.3 (#7583) Fix for issue 7416: font size of the preferences dialog does not update with the rest of the GUI. (#7509) Fix school/instituation is printed twice (#7574)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7416
The font size of preferences dialog does not update after changing the main font size. I think this problem is about the style settings of the dialog. Therefore, in the constructor of
PreferencesDialogViewclass, I assigned the main font size to the font size of the dialog viasetStyle().CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)