Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue of Changing font size makes font size field too small #7398

Merged
merged 4 commits into from
Feb 1, 2021

Conversation

Landi29
Copy link
Contributor

@Landi29 Landi29 commented Jan 31, 2021

Description:

As the preferred width for the fontsize spinner under prefrences/appearence was set to a fixed pixel size, I changed it to use the em measure instead. A style class called fontsizeSpinner was added to Base.css with this change.
Fixes #7085.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Screenshots:

Skærmbillede fra 2021-01-31 02-33-56

@Landi29
Copy link
Contributor Author

Landi29 commented Jan 31, 2021

Any idea why the check "Deployment / Create installer and portable version for macOS (pull_request) " fails? Under the step Setup OSX key chain on OSX it fails with the message: Error: At least one of p12-filepath or p12-file-base64 must be provided.

@Siedlerchr
Copy link
Member

The OSX build requires some secrets that aren't available in forks. So simply ignore it. Maybe I can disable the Mac build for forks

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Welcome to JabRef, and thanks a lot for your contribution.

Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. Merging now.

@calixtus calixtus changed the title fixes issue of Changing font size makes font size field too small Fixes issue of Changing font size makes font size field too small Feb 1, 2021
@calixtus calixtus merged commit 1f42928 into JabRef:master Feb 1, 2021
Siedlerchr added a commit that referenced this pull request Feb 1, 2021
* upstream/master:
  Bump archunit-junit5-api from 0.15.0 to 0.16.0 (#7407)
  Bump classgraph from 4.8.98 to 4.8.102 (#7401)
  Bump archunit-junit5-engine from 0.15.0 to 0.16.0 (#7402)
  Bump mariadb-java-client from 2.7.1 to 2.7.2 (#7406)
  Bump org.beryx.jlink from 2.23.2 to 2.23.3 (#7400)
  Bump checkstyle from 8.39 to 8.40 (#7404)
  Ignore codecov status for automerge
  Fixes issue of Changing font size makes font size field too small (#7398)
  fix "Alt + keyboard shortcuts do not work" (#7379)
  Fixed invisible file path in the dark theme (#7396)
  Fix File Filter and some layout issues (#7385)
  Feature/implement complex queries (#7350)
  Change format for study definition to yaml (#7126)
  Fix handling of URL in file field (#7347)
  Fix expansion of bracketed expressions in RegExpBasedFileFinder (#7338)
@Landi29 Landi29 deleted the fix-for-issue-7085 branch February 2, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing font size makes font size field too small
4 participants