Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed invisible file path in the dark theme #7396

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Fixed invisible file path in the dark theme #7396

merged 2 commits into from
Jan 30, 2021

Conversation

Fu188
Copy link
Contributor

@Fu188 Fu188 commented Jan 30, 2021 •
edited
Loading

In the original version, the file path is not visually good due to its font color. After a hard debuging process, I find that we don't bind the property of text with "css" and then the text color is black by default. Such that, I bind them and change the color the text and it looks wonderful now. Fixes #7382

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Light Theme
image

Dark Theme
image

Siedlerchr
Siedlerchr approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, lgtm

calixtus
calixtus approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, codewise looks good to me, I wonder why this is not inherited.

@calixtus calixtus changed the title Fix the issue where the file path is invisible in the dark theme Fixed invisible file path in the dark theme Jan 30, 2021
@calixtus calixtus merged commit e4c83cf into JabRef:master Jan 30, 2021
Siedlerchr added a commit that referenced this pull request Feb 1, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixlayoutauthors
a44f589 
* upstream/master:
  Bump archunit-junit5-api from 0.15.0 to 0.16.0 (#7407)
  Bump classgraph from 4.8.98 to 4.8.102 (#7401)
  Bump archunit-junit5-engine from 0.15.0 to 0.16.0 (#7402)
  Bump mariadb-java-client from 2.7.1 to 2.7.2 (#7406)
  Bump org.beryx.jlink from 2.23.2 to 2.23.3 (#7400)
  Bump checkstyle from 8.39 to 8.40 (#7404)
  Ignore codecov status for automerge
  Fixes issue of Changing font size makes font size field too small (#7398)
  fix "Alt + keyboard shortcuts do not work" (#7379)
  Fixed invisible file path in the dark theme (#7396)
  Fix File Filter and some layout issues (#7385)
  Feature/implement complex queries (#7350)
  Change format for study definition to yaml (#7126)
  Fix handling of URL in file field (#7347)
  Fix expansion of bracketed expressions in RegExpBasedFileFinder (#7338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark Theme visibility of File path
3 participants
@Fu188 @Siedlerchr @calixtus