-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP/Testing] Test Module Issue #7146
Conversation
Signed-off-by: Dominik Voigt <[email protected]>
Signed-off-by: Dominik Voigt <[email protected]>
This is really terrible... it essentially means that we cannot add any (sufficiently) large dependency. Shit... Can you please try remove jgit and load add some random other library, just to exclude that jgit is not the source. Then we should also think about how to proceed from here. Two obvious ways would be to remove some old libraries (antlr e.g.) and some less-used features (vm), maybe even to the extend to provide them as plugins (libreoffice) although I really don't wanna go this way. |
Now we get a different exception for some modules:
|
* upstream/master: Improve library loading UX (#7119) remove jython (#7157) Add missing authors Remove obsolete hint Fixed issue in PreviewView for number textfield (#7158) Fix for issue 6959 (#7151) Revert "remove jython (#7155)" (#7156) remove jython (#7155) Fix remembering password for sql db (#7154) Update to libre office 7.0.3 (#7150) Add IdBasedSearchFetcher to jstor (#7145) Squashed 'src/main/resources/csl-styles/' changes from 55200d0..a20406d Bump antlr4-runtime from 4.8-1 to 4.9 (#7136)
@DominikVoigt seems to work again |
…into test-module-issue
* upstream/master: (33 commits) Bump archunit-junit5-api from 0.14.1 to 0.15.0 (#7220) Bump unoloader from 7.0.3 to 7.0.4 (#7214) Bump guava from 30.0-jre to 30.1-jre (#7218) Bump xmpbox from 2.0.21 to 2.0.22 (#7217) Bump classgraph from 4.8.94 to 4.8.97 (#7211) Bump byte-buddy-parent from 1.10.18 to 1.10.19 (#7216) Bump archunit-junit5-engine from 0.14.1 to 0.15.0 (#7215) Bump org.beryx.jlink from 2.22.3 to 2.23.0 (#7212) Add missing author Remove field check for journal abbrev in entry editor (#7208) Improvements for Entry Preview (in the context of #7083 and in addition to #7093) (#7185) Fix pdf content importer exception if DOI is empty (#7207) New translations JabRef_en.properties (Turkish) (#7204) New Crowdin updates (#7198) New Crowdin updates (#7192) Added missing test Changed tests to parameterized tests Extraction of Globals.prefs.put and .get (#7121) Fix newly added entry not synced to db (#7178) Bump org.eclipse.jgit from 5.9.0.202009080501-r to 5.10.0.202012080955-r (#7187) ...
…hy with updated build plugins and ASM @koppor
For reference:
|
Did you already experimented with removing jgit again? Hopefully (maybe) this dependency explodes the module tree?! Also, can someone post the content of the class file that is to large (I think it should be jdk.internal.module.SystemModules$all)? Then we can maybe see where the methods are coming from. |
* updateGradle7: (39 commits) try upgrading gradle Only disable move to file dir when path equals (#7269) Improved detection of long DOI's within text (#7260) Add missing author and fix name Fix style of highlighted checkboxes while searching in preferences (#7258) Updates to institution citation keys (#7210) Bump xmlunit-core from 2.8.1 to 2.8.2 (#7251) Bump classgraph from 4.8.97 to 4.8.98 (#7250) Bump bcprov-jdk15on from 1.67 to 1.68 (#7249) Bump xmlunit-matchers from 2.8.1 to 2.8.2 (#7252) Bump unirest-java from 3.11.06 to 3.11.09 (#7254) Bump org.beryx.jlink from 2.23.0 to 2.23.1 (#7253) Bump pascalgn/automerge-action from v0.12.0 to v0.13.0 (#7255) Added a check to integrate with the flatpak package (#7248) New translations JabRef_en.properties (Chinese Traditional) (#7247) Update code-howtos.md GitBook: [master] 5 pages and 25 assets modified New Crowdin updates (#7246) add language mapping for chinese remove chinese content ...
jdk16 not yet supported
Even with gradle 6.7 this fails. |
Can you please post the content of that file? (I don't have a working jdk available at the moment) |
Possible workaround: beryx/badass-jlink-plugin#168 (comment) |
* upstream/master: (34 commits) Fixed exception about missing custom css file (#7292) Update the templates for opening a new issue (#7321) Entitlements file Mac (#7317) Make CONTRIBUTING.md much shorter. Move long text to docs/contributing.md (#7293) Include Github-optimized screenshot into repository (#7318) Remove obsolete registry patch file (#7316) Fix AUTHORS GitBook: [master] one page modified Remove broken Sonarqube integration (#7315) GitBook: [master] 5 pages and 32 assets modified docs: update license year (#7314) Add javafx version number + update javafx (#7312) Add missing authors Adjust zbmath fetcher (#7298) Add "acm-siggraph.csl" required by CitationStyle.java Added Keyboard shortcuts (clear/set read status) (#7302) Add special fields ADR (#7300) Overwrite local copies Squashed 'buildres/csl/csl-locales/' content from commit ecb8e70233 Squashed 'buildres/csl/csl-styles/' content from commit 737ffa1 ...
Closing, because we work at #7126. |
This PR is used to test whether the module issue is caused by jackson directly
For reference, java bug: https://bugs.openjdk.java.net/browse/JDK-8246197