Skip to content

Commit

Permalink
Demonstrate JLink build for module-info of size 92kb in build hierarc…
Browse files Browse the repository at this point in the history 
…hy with updated build plugins and ASM

@koppor
  • Loading branch information
@GedMarc
GedMarc committed Dec 29, 2020
1 parent 72754bc commit 511b565
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions project1/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,11 @@
<artifactId>hibernate-core</artifactId>
</dependency>

<dependency>
<!-- 2020/12/29 @gedmarc - latest pf update made module-info @todo fix pf module-info -->
<!--<dependency>
<groupId>com.guicedee.services</groupId>
<artifactId>primefaces</artifactId>
</dependency>
</dependency>-->


<dependency>
Expand Down

6 comments on commit 511b565

@GedMarc
Copy link
Owner Author

@GedMarc GedMarc commented on 511b565 Dec 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@koppor it is resolved :) check all the version updates in the main pom in the top properties section

@GedMarc
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll do a 0_SNAPSHOT build now and deploy to central

@GedMarc
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koppor i have no idea how github actions work - are you able to update the build to mimic a mvn install from the command line?

@GedMarc
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also check this one i found when there is a module-info in the root, and in the versions/11 package, this closed as not a bug, but breaks the jlink build as well - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8256248

i think there was a module in that version where this one was the problem actually.... why am I struggling to find the closed bug for this ....

@GedMarc
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blah i just cleanup up all the modules properly - reproduced

@koppor
Copy link
Collaborator

@koppor koppor commented on 511b565 Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blah i just cleanup up all the modules properly - reproduced

Good to hear. Otherwise, we had experienced some different bug at JabRef/jabref#7146.

Please sign in to comment.