Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Demonstrate JLink build for module-info of size 92kb in build hierarc…
…hy with updated build plugins and ASM @koppor
- Loading branch information
511b565
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koppor it is resolved :) check all the version updates in the main pom in the top properties section
511b565
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll do a 0_SNAPSHOT build now and deploy to central
511b565
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koppor i have no idea how github actions work - are you able to update the build to mimic a mvn install from the command line?
511b565
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also check this one i found when there is a module-info in the root, and in the versions/11 package, this closed as not a bug, but breaks the jlink build as well - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8256248
i think there was a module in that version where this one was the problem actually.... why am I struggling to find the closed bug for this ....
511b565
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blah i just cleanup up all the modules properly - reproduced
511b565
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to hear. Otherwise, we had experienced some different bug at JabRef/jabref#7146.