Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability for citation key patterns #6706

Merged
merged 45 commits into from
Sep 21, 2020
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
360cfda
Drop `authEtal` dependence on alphabetization
k3KAW8Pnf7mkmdSMPHz27 Jul 10, 2020
aa30930
Drop use of deprecated method
k3KAW8Pnf7mkmdSMPHz27 Jul 14, 2020
4126163
Drop unnecessary method call
k3KAW8Pnf7mkmdSMPHz27 Jul 14, 2020
09f3ca2
Fix test using `nio.file.Path`
k3KAW8Pnf7mkmdSMPHz27 Jul 14, 2020
facada6
Refactor if-else block to switch
k3KAW8Pnf7mkmdSMPHz27 Jul 17, 2020
9e93fe9
Add parsing of authors as an AuthorList
k3KAW8Pnf7mkmdSMPHz27 Jul 17, 2020
ddf3c6f
Merge branch 'master' into fix-for-issue-3920
k3KAW8Pnf7mkmdSMPHz27 Jul 17, 2020
812b9ac
Fix handling of list of authors
k3KAW8Pnf7mkmdSMPHz27 Jul 21, 2020
15770de
Refactor variable name
k3KAW8Pnf7mkmdSMPHz27 Jul 21, 2020
d456d1e
Fix adding institutions twice
k3KAW8Pnf7mkmdSMPHz27 Jul 21, 2020
53f705c
Fix attempting to improve readability
k3KAW8Pnf7mkmdSMPHz27 Jul 21, 2020
e62481a
Fix types and readability
k3KAW8Pnf7mkmdSMPHz27 Jul 23, 2020
e0c7507
Refactor `firstAuthorVonAndLast`
k3KAW8Pnf7mkmdSMPHz27 Jul 23, 2020
a86ce94
Fix access modifiers
k3KAW8Pnf7mkmdSMPHz27 Aug 7, 2020
6a836f2
Merge branch 'master' into fix-for-issue-3920
k3KAW8Pnf7mkmdSMPHz27 Aug 7, 2020
8d1774b
Add test case
k3KAW8Pnf7mkmdSMPHz27 Aug 7, 2020
cf203c9
Drop unused methods
k3KAW8Pnf7mkmdSMPHz27 Aug 7, 2020
715364d
Add tests for truncated Unicode
k3KAW8Pnf7mkmdSMPHz27 Aug 18, 2020
ee94869
Fix missing bracket in test case
k3KAW8Pnf7mkmdSMPHz27 Aug 18, 2020
ed66bb2
Add convenience method for cleaning cite keys
k3KAW8Pnf7mkmdSMPHz27 Aug 27, 2020
5b1312f
Fix incorrect number of characters in cite key
k3KAW8Pnf7mkmdSMPHz27 Aug 27, 2020
864c0ba
Fix incorrect number of characters in cite key
k3KAW8Pnf7mkmdSMPHz27 Aug 27, 2020
9cac2db
Merge remote-tracking branch 'origin/fix-for-issue-3920' into fix-for…
k3KAW8Pnf7mkmdSMPHz27 Aug 27, 2020
25de361
Merge branch 'master' into fix-for-issue-3920
k3KAW8Pnf7mkmdSMPHz27 Aug 27, 2020
472537c
Fix readability in BracketedPattern.expandBrackets
k3KAW8Pnf7mkmdSMPHz27 Aug 28, 2020
0b3a58c
Fix names in BracketedPattern.expandBrackets
k3KAW8Pnf7mkmdSMPHz27 Aug 31, 2020
4fe9774
Add JavaDoc to constants
k3KAW8Pnf7mkmdSMPHz27 Aug 31, 2020
a1a737b
Fix readability in BracketedPattern#authorsAlpha
k3KAW8Pnf7mkmdSMPHz27 Aug 31, 2020
4d19a51
Fix reformatting of file and readability
k3KAW8Pnf7mkmdSMPHz27 Aug 31, 2020
70a9fde
Fix simplifying camelizeSignificantWordsInTitle
k3KAW8Pnf7mkmdSMPHz27 Aug 31, 2020
663a836
Fix construction of BibEntry
k3KAW8Pnf7mkmdSMPHz27 Aug 31, 2020
4cba99c
Fix removing a null variable
k3KAW8Pnf7mkmdSMPHz27 Aug 31, 2020
bde6303
Add test for parsing of brackets in regex
k3KAW8Pnf7mkmdSMPHz27 Sep 3, 2020
4f72ef5
Merge branch 'fix-for-issue-3920' of https://github.com/k3KAW8Pnf7mkm…
k3KAW8Pnf7mkmdSMPHz27 Sep 3, 2020
11cbc14
Fix construction of BibEntries
k3KAW8Pnf7mkmdSMPHz27 Sep 3, 2020
7c2bcd0
Fix new line in JavaDoc
k3KAW8Pnf7mkmdSMPHz27 Sep 3, 2020
9b68687
Fix inconsistent bracket use in test patterns
k3KAW8Pnf7mkmdSMPHz27 Sep 3, 2020
de93751
Fix more BibEntries constructions
k3KAW8Pnf7mkmdSMPHz27 Sep 3, 2020
609caa7
Merge branch 'master' into fix-for-issue-3920
k3KAW8Pnf7mkmdSMPHz27 Sep 14, 2020
2c73301
Fix mistake in merge
k3KAW8Pnf7mkmdSMPHz27 Sep 14, 2020
23764b4
Fix use of withCiteKey
k3KAW8Pnf7mkmdSMPHz27 Sep 21, 2020
aca6fb1
Fix logger output
k3KAW8Pnf7mkmdSMPHz27 Sep 21, 2020
7b89653
Fix logger output
k3KAW8Pnf7mkmdSMPHz27 Sep 21, 2020
eac7293
Fix logger output
k3KAW8Pnf7mkmdSMPHz27 Sep 21, 2020
d598f41
Drop test-case outside of PR scope
k3KAW8Pnf7mkmdSMPHz27 Sep 21, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1094,4 +1094,20 @@ void generateKeyWithWithFirstNCharacters() {

assertEquals("newt-2019", generateKey(entry, "[auth4:lower]-[year]"));
}

@Test
void generateKeyCorrectKeyLengthWithTruncateModifierAndUnicode() {
BibEntry bibEntry = new BibEntry();
bibEntry.setField(StandardField.AUTHOR, "Gödel, Kurt");

assertEquals(2, generateKey(bibEntry, "[auth:truncate2").length());
k3KAW8Pnf7mkmdSMPHz27 marked this conversation as resolved.
Show resolved Hide resolved
}

@Test
void generateKeyCorrectKeyLengthWithAuthNofMthAndUnicode() {
BibEntry bibEntry = new BibEntry();
bibEntry.setField(StandardField.AUTHOR, "Gödel, Kurt");

assertEquals(4, generateKey(bibEntry, "[auth4_1]").length());
}
}