Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readability for citation key patterns #6706

Merged
merged 45 commits into from
Sep 21, 2020
Merged

Readability for citation key patterns #6706

merged 45 commits into from
Sep 21, 2020

Commits on Jul 10, 2020

  1. Drop authEtal dependence on alphabetization

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    360cfda View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Drop use of deprecated method 

    Inlining the deprecated method.
    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    aa30930 View commit details
    Browse the repository at this point in the history

  2. Drop unnecessary method call 

    Any references in the `String` should already have been resolved by
`getResolvedFieldOrAlias`.
    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    4126163 View commit details
    Browse the repository at this point in the history

  3. Fix test using nio.file.Path 

    On Mac OS X this test case generates an error. The changes should
reflect the intent of the test (i.e., are the lists referring to the
same files).
    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    09f3ca2 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. Refactor if-else block to switch

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    facada6 View commit details
    Browse the repository at this point in the history

  2. Add parsing of authors as an AuthorList

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    9e93fe9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix-for-issue-3920

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    ddf3c6f View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Fix handling of list of authors

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    812b9ac View commit details
    Browse the repository at this point in the history

  2. Refactor variable name

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    15770de View commit details
    Browse the repository at this point in the history

  3. Fix adding institutions twice

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    d456d1e View commit details
    Browse the repository at this point in the history

  4. Fix attempting to improve readability

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    53f705c View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Fix types and readability 

    String[] changed to List<String> and some refactoring
    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    e62481a View commit details
    Browse the repository at this point in the history

  2. Refactor firstAuthorVonAndLast

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    e0c7507 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. Fix access modifiers

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    a86ce94 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-for-issue-3920

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    6a836f2 View commit details
    Browse the repository at this point in the history

  3. Add test case

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    8d1774b View commit details
    Browse the repository at this point in the history

  4. Drop unused methods

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    cf203c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. Add tests for truncated Unicode 

    The tests check if authors with names containing Unicode returns the
correct number of characters in the citation key.
    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    715364d View commit details
    Browse the repository at this point in the history

  2. Fix missing bracket in test case 

    Co-authored-by: Oliver Kopp <[email protected]>
    @k3KAW8Pnf7mkmdSMPHz27 @koppor
    k3KAW8Pnf7mkmdSMPHz27 and koppor authored Aug 18, 2020
    Configuration menu
    Copy the full SHA
    ee94869 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Add convenience method for cleaning cite keys

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    ed66bb2 View commit details
    Browse the repository at this point in the history

  2. Fix incorrect number of characters in cite key 

    The result of expanding a bracket must be cleaned before applying
modifiers that depends on the number of characters in the result.
(truncate)
    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    5b1312f View commit details
    Browse the repository at this point in the history

  3. Fix incorrect number of characters in cite key 

    This fix extends a previous workaround in BracketedPattern.authN. It
does not solve the underlying issue.
    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    864c0ba View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/fix-for-issue-3920' into fix-for… 

    …-issue-3920
    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    9cac2db View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fix-for-issue-3920

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    25de361 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Fix readability in BracketedPattern.expandBrackets

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    472537c View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Fix names in BracketedPattern.expandBrackets

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    0b3a58c View commit details
    Browse the repository at this point in the history

  2. Add JavaDoc to constants

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    4fe9774 View commit details
    Browse the repository at this point in the history

  3. Fix readability in BracketedPattern#authorsAlpha

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    a1a737b View commit details
    Browse the repository at this point in the history

  4. Fix reformatting of file and readability

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    4d19a51 View commit details
    Browse the repository at this point in the history

  5. Fix simplifying camelizeSignificantWordsInTitle

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    70a9fde View commit details
    Browse the repository at this point in the history

  6. Fix construction of BibEntry 

    Co-authored-by: Oliver Kopp <[email protected]>
    @k3KAW8Pnf7mkmdSMPHz27 @koppor
    k3KAW8Pnf7mkmdSMPHz27 and koppor authored Aug 31, 2020
    Configuration menu
    Copy the full SHA
    663a836 View commit details
    Browse the repository at this point in the history

  7. Fix removing a null variable

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    4cba99c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Add test for parsing of brackets in regex

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    bde6303 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix-for-issue-3920' of https://github.com/k3KAW8Pnf7mkm… 

    …dSMPHz27/jabref into fix-for-issue-3920
    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    4f72ef5 View commit details
    Browse the repository at this point in the history

  3. Fix construction of BibEntries

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    11cbc14 View commit details
    Browse the repository at this point in the history

  4. Fix new line in JavaDoc

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    7c2bcd0 View commit details
    Browse the repository at this point in the history

  5. Fix inconsistent bracket use in test patterns

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    9b68687 View commit details
    Browse the repository at this point in the history

  6. Fix more BibEntries constructions

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    de93751 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Merge branch 'master' into fix-for-issue-3920 

    # Conflicts:
#	src/test/java/org/jabref/logic/citationkeypattern/BracketedPatternTest.java
#	src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java
    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    609caa7 View commit details
    Browse the repository at this point in the history

  2. Fix mistake in merge

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    2c73301 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Fix use of withCiteKey

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    23764b4 View commit details
    Browse the repository at this point in the history

  2. Fix logger output 

    Co-authored-by: Oliver Kopp <[email protected]>
    @k3KAW8Pnf7mkmdSMPHz27 @koppor
    k3KAW8Pnf7mkmdSMPHz27 and koppor authored Sep 21, 2020
    Configuration menu
    Copy the full SHA
    aca6fb1 View commit details
    Browse the repository at this point in the history

  3. Fix logger output 

    Co-authored-by: Oliver Kopp <[email protected]>
    @k3KAW8Pnf7mkmdSMPHz27 @koppor
    k3KAW8Pnf7mkmdSMPHz27 and koppor authored Sep 21, 2020
    Configuration menu
    Copy the full SHA
    7b89653 View commit details
    Browse the repository at this point in the history

  4. Fix logger output

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    eac7293 View commit details
    Browse the repository at this point in the history

  5. Drop test-case outside of PR scope

    @k3KAW8Pnf7mkmdSMPHz27
    k3KAW8Pnf7mkmdSMPHz27 committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    d598f41 View commit details
    Browse the repository at this point in the history