Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge identical group colors #6566

Closed
wants to merge 4 commits into from
Closed

Conversation

WangAooa
Copy link
Contributor

Fixes #6175
Hi, I made some mistake that close the PR. This is a new PR about #6175 issue.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@calixtus
Copy link
Member

calixtus commented Jun 1, 2020

Hi @WangAooa , thanks for reintroducing this PR. However, @tobiasdiez asked for some changes in the other PR. Please fix the checkstyle issues and consider the changes he asked for.

@calixtus
Copy link
Member

calixtus commented Jun 1, 2020

#6491 (review)

@tobiasdiez tobiasdiez added the status: changes required Pull requests that are not yet complete label Jun 4, 2020
@koppor koppor changed the title Fix 6175 Merge identical group colors Jun 16, 2020
@koppor
Copy link
Member

koppor commented Jul 7, 2020

This is a good start. Since there was no activity since a few weeks, we would like to ask whether there is some interest in continuing in this.

@calixtus calixtus self-assigned this Aug 18, 2020
@calixtus
Copy link
Member

Hi @WangAooa , since there was no progress here and we like the idea, we gonna take this over and finish it soon. Thanks for your work.

@calixtus calixtus closed this Aug 18, 2020
@calixtus calixtus reopened this Aug 18, 2020
@calixtus calixtus closed this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: changes required Pull requests that are not yet complete status: stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group color, only display identical colors once
4 participants