Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group color, only display identical colors once #6175

Closed
Yery opened this issue Mar 25, 2020 · 10 comments · Fixed by #6768
Closed

Group color, only display identical colors once #6175

Yery opened this issue Mar 25, 2020 · 10 comments · Fixed by #6768
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement ui

Comments

@Yery
Copy link

Yery commented Mar 25, 2020

Suppose i have the following Categories and Subcategories
Category: Food: Subcategory: Nuts
Category: Trees: Subcategory: Nut trees

Now it is possible (and makes sense) to assign a single colour to both subcategory Nuts and Nut trees. Some papers however, will naturally be categorized in both groups. In such instances, Jabref currently displays twice the colour in the main table (in the column group color). Would it be possible to only display the unique colours?

I hope this (rather contrived) example is clear. Please let me know if not!

@tobiasdiez tobiasdiez added type: enhancement good first issue An issue intended for project-newcomers. Varies in difficulty. labels Mar 25, 2020
@WangAooa
Copy link
Contributor

Hi, I'd like to contribute to this issue.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

I were not intending to contribute to this issue. I am just wondering if it makes sense to have some kind of sort based on color as distinct() and similar solutions are not stable?

@LuckyOne09
Copy link
Contributor

I am wondering the meaning of this issue because I think it is reasonable to display multiple colors if this paper belongs to multiple subgroups. If you want to display only one color, how to choose the color from multiple groups it is in?

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented May 4, 2020

If I understand @Yery correctly multiple different colors should be displayed, as long as they are distinct?

@Yery
Copy link
Author

Yery commented May 4, 2020

@k3KAW8Pnf7mkmdSMPHz27
Thanks, yes, that is what I meant. It is of course good to see different colours, the issue is on merging multiple identical colours.

@LuckyOne09
Copy link
Contributor

@k3KAW8Pnf7mkmdSMPHz27 @Yery Thanks for your explanations, but since it is possible that users give identical colors to two groups which are not relevant, I think it is troublesome to distinguish which identical colors should be merged and which should not.

@Yery
Copy link
Author

Yery commented May 4, 2020

To me it simply doesn't make sense to have two or three times the same colour, and these should always be merged, otherwise the user should use different colours. The example I gave illustrates a situation where a user would want to chose the same colour (and would like to have them merged). For my user case, I would use this feature a lot.

@WangAooa
Copy link
Contributor

WangAooa commented May 5, 2020

So, can I combine all colors together and provide a new color if it has multiple colors? I'm a little confused about the above discussion.

@Siedlerchr
Copy link
Member

I think the main point is that we are talking about subgroups

@Yery
Copy link
Author

Yery commented May 5, 2020

Sorry this is confusing, but this issue is just about merging identical colours (so not displaying them twice, which looks silly), so:

red | red = red
red | green | blue = red | green | blue
red | green | red = red | green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement ui
Projects
Archived in project
6 participants