Fix for issue 5463 #5481
Fix for issue 5463 #5481
Conversation
There was a problem hiding this comment.
Please merge the latest changes from upstream master into your code and then I guess you can use the already defined css styles from Dark.css for the preview by adding the references to them to the <body> tag that has been added recently by @tobiasdiez as he has introduced a new marking function (see https://github.com/JabRef/jabref/pull/5472/files).
merge with origin/master
There was a problem hiding this comment.
Thanks for your contribution and welcome to JabRef! 😻
@matthiasgeiger proposed a neat way to solve this issue, but it's a bit more work (see below for details). So if you should encounter any problems while implementing this, feel free to reach out to us and we will work on it together!
Finally, our stupid bot complains about your code style 😈. You can see the error messages by clicking on "Details" below next to the failing test. But luckily it's only a bunch of missing new lines, which should be easy to fix.
|
Good work 👍 I'll merge this PR now. I hope you enjoyed contributing to JabRef. I would like to continue working with you. What do you think about resolving #5485? This issue was recently reported and is about an important feature of JabRef. |
# By Tobias Diez (11) and others # Via GitHub (30) and others * upstream/master: (70 commits) Use Platform.runLater Fixes #5485 Bump com.github.ben-manes.versions from 0.26.0 to 0.27.0 Bump src/main/resources/csl-styles from `68a697b` to `c3fd4bd` Bump byte-buddy-parent from 1.10.1 to 1.10.2 Bump mariadb-java-client from 2.5.0 to 2.5.1 Bump classgraph from 4.8.48 to 4.8.52 Bump org.beryx.jlink from 2.16.0 to 2.16.2 Updated CHANGELOG.md Open entry editor by default on start-up Amend the reference to JabRefReferences initialization (#5487) Fix for issue 5463 (#5481) Rename index.md to README.md Fix not on fx thread error for custom entry types Refactor to sorted set (#5477) Removed a duplicate name (closes #5476) Remove unnecessary sort (#5470) lint CONTRIBUTING.md (#5473) Mark OOSTyle as invalid if no defaultStyle (#5471) Fix highlight problem in entry preview ... # Conflicts: # build.gradle
Fixed issue #5463 (#5463)
Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)