Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary sort #5470

Merged
merged 4 commits into from
Oct 17, 2019
Merged

Remove unnecessary sort #5470

merged 4 commits into from
Oct 17, 2019

Conversation

JoHaHu
Copy link
Contributor

@JoHaHu JoHaHu commented Oct 17, 2019 •
edited
Loading

The list gets sorted in WebFetchers.getSearchBasedFetchers before
Therefore its not necessary to sort it again.

Johannes Hupe added 2 commits October 17, 2019 19:29
Remove unnecessary sort
e91cc71 
The list gets sorted before. Therefore its not necessary to sort it again.
Remove unnecessary sort
465186b 
The list gets sorted before. Therefore its not necessary to sort it again.
@koppor
Copy link
Member

koppor commented Oct 17, 2019

Please add a comment to each public method at https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/logic/importer/WebFetchers.java that the list is sorted. Otherwise, that functionality could be changed and the contract would still be valid.

Refs #3023, because Eclipse Collections offers better datatypes. Here, ImmutableSortedSet would IMHO be the best result type.

@koppor
Copy link
Member

koppor commented Oct 17, 2019

BTW: Thank you so much for your first JabRef code. Really like to see that you changed some code (and not some typos).

@tobiasdiez
Copy link
Member

@koppor raises a valid point, if the method returns just a "list" than it's safe to assume that its not sorted. So please change the return type to SortedList.

@JoHaHu JoHaHu marked this pull request as ready for review October 17, 2019 21:49
@LinusDietz LinusDietz merged commit bc26c3a into JabRef:master Oct 17, 2019
koppor
koppor reviewed Oct 18, 2019
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please work on a follow up PR not adding GUI library dependencies. In case the standard library does not support it, add Eclipse Collections.

src/main/java/org/jabref/logic/importer/WebFetchers.java
@@ -5,6 +5,10 @@
import java.util.List;
import java.util.Optional;

import javafx.collections.FXCollections;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no JavaFX imports. Our logic module must not have any imports from the gui. This blocks #110

Why do our architecture tests not fail here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should i refactor to standard library SortedSet?
In case Eclipse Collections is added as dependency later on, ImmutableSortedSet can be used as drop in replacement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, SortedSet might be the better option here (because Set would be already better than List as the elements should be unique). Could you please create a follow-up PR? Sorry for the overhead, was my bad.

@koppor koppor mentioned this pull request Oct 18, 2019
Open
@JoHaHu JoHaHu deleted the cleanups branch October 18, 2019 12:13
@JoHaHu JoHaHu mentioned this pull request Oct 18, 2019
Merged
3 tasks
Siedlerchr added a commit that referenced this pull request Oct 24, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into convertRemainingTest
2041c5b 
# By Tobias Diez (11) and others
# Via GitHub (30) and others
* upstream/master: (70 commits)
  Use Platform.runLater
  Fixes #5485
  Bump com.github.ben-manes.versions from 0.26.0 to 0.27.0
  Bump src/main/resources/csl-styles from `68a697b` to `c3fd4bd`
  Bump byte-buddy-parent from 1.10.1 to 1.10.2
  Bump mariadb-java-client from 2.5.0 to 2.5.1
  Bump classgraph from 4.8.48 to 4.8.52
  Bump org.beryx.jlink from 2.16.0 to 2.16.2
  Updated CHANGELOG.md
  Open entry editor by default on start-up
  Amend the reference to JabRefReferences initialization (#5487)
  Fix for issue 5463 (#5481)
  Rename index.md to README.md
  Fix not on fx thread error for custom entry types
  Refactor to sorted set (#5477)
  Removed a duplicate name (closes #5476)
  Remove unnecessary sort (#5470)
  lint CONTRIBUTING.md (#5473)
  Mark OOSTyle as invalid if no defaultStyle (#5471)
  Fix highlight problem in entry preview
  ...

# Conflicts:
#	build.gradle
koppor pushed a commit that referenced this pull request Jun 15, 2021
Squashed 'buildres/csl/csl-styles/' changes from e1acabe..a3706b1
dbb93e7 
a3706b1 Fix ArchéoSciences (#5506)
daeadd3 Update hawaii-international-conference-on-system-sciences-proceedings… (#5505)
225b9c0 Create saglik-bilimleri-universitesi.csl (#5295)
7205734 Create health-education-england-harvard-citation-style.csl (#5345)
b2085cb Adicionar ponto e espaço antes de "Disponível em:" (#5367)
f3eb50a Create apa6-for-international-journal-of-learner-corpus-research.csl (#5430)
ff34f5c Update fachhochschule-vorarlberg-note.csl (#5502)
5aa48f7 Update fachhochschule-vorarlberg-author-date.csl (#5501)
717fba3 Create apa6-for-register-studies.csl (#5458)
147689b Update food-and-agriculture-organization-of-the-united-nations.csl  (#5492)
e35ae39 New citation style: "Norsk henvisningsstandard for rettsvitenskapelige tekster" (validated) (#5494)
7ff9389 revise Manchester Univ. Press style (note-bib) (#5500)
9e97809 move citation number outside first field (#5499)
b08e5d7 Update APA disambiguation rules to only initials (#5498)
5d1629f Create arbok-hins-islenzka-fornleifafelags.csl (#5497)
3a2ff5f Create novasinergia.csl (#5489)
35920e2 Update din-1505-2.csl (#5491)
197486e Create zeitschrift-fuer-fantastikforschung.csl (#5490)
2cd6364 Create artificial-organs.csl (#5340)
5ea7955 Create society-of-biblical-literature-1st-edition-fullnote-bibliography (#5421)
d0de451 Create Journal of Move and Therapeutic Science (#5486)
899c2bc Update ACS documentation & date format
950f730 Create ulua-revista-de-historia-sociedad-y-cultura.csl (#5478)
a1c34f5 Update wirtschaftsuniversitat-wien-institut-fur-bwl-des-aussenhandels.csl (#5470)
79fa66e Update gallia-prehistoire.csl (#5467)
2f1df12 Update hochschule-bonn-rhein-sieg.csl (#5479)
06078c6 Update acta-universitatis-agriculturae-sueciae.csl (#5409)
3650206 Update ethnographiques-org.csl (#5480)
e06cc90 remove et-al from restoration-ecology.csl (#5485)
4e4e1f3 Presses universitaires de Strasbourg – Fix op.cit and multiple items (#5484)
f8ff160 Create UWE-Bristol-Harvard-2021.csl (#5482)
10a1d17 Fix authors delimiter (#5483)
f53ff57 Update stuttgart-media-university.csl (#5477)
c7a01e0 Create worlds-veterinary-journal.csl (#5468)
ec923b2 Update experimental-biology-and-medicine.csl (#5469)
1d48cb7 Create plant-species-biology.csl (#5471)
ea68765 Create ethnographiques-org.csl (#5472)
0e1c470 Update harvard-bournemouth-university.csl (#5476)
96e8114 Use date issued in web documents if exists (#5418)
8377ec8 Create bibliothecae-it.csl (#5440)
a5707e7 Create bppb.csl (#5452)
dc0e509 Create babesch-annual-papers-on-mediterranean-archaeology.csl (#5424)
62aa816 Bump nokogiri from 1.11.1 to 1.11.4 (#5460)
47a603c Update society-of-biblical-literature-fullnote-bibliography.csl (#5436)
1de799b SAA: Update disambiguation
46da8c6 Update iso690-author-date-cs.csl (#5443)
2a74991 Exempt ISSNs for Topoi journal (#5444)
a0f3130 show test directories
f9ce567 Updates ( -> [ (#5347)
c3910dd IEEE.csl - Add "I. Online Video (e.g., YouTube)" (#5365)
d37f39a Update estudios-hispanicos.csl (#5417)
931c057 Create topoi-orient-occident-classique.csl (#5427)
70ee747 Create topoi-orient-occident-auteur-date.csl (#5426)
8ea5ed2 Update universite-de-montreal-apa.csl (#5428)
f0dcb04 Update the-horticulture-journal.csl (#5437)
767df6d Update transnational-environmental-law.csl (#5435)
1e63dfe Update environmental-values.csl to match requirements (#5355)
94163d8 Create studies-in-the-history-of-gardens-and-designed-landscapes.csl (#5425)
21dd881 Create journal-of-stroke.csl (#5429)
937ce4b Update the-plant-genome.csl (#5432)
996e217 Update springer-basic-author-date-no-et-al.csl (#5431)
7dd1f44 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5433)
141be9b Update civilta-italiana.csl (#5434)
10b2222 small fixes for jopr.csl (#5422)
bf59a9f Create jci-insight.csl (#5423)
9aebd58 Update mammalia.csl (#5404)
77dcd74 Update gost-r-7-0-5-2008 styles (#5412)
5d348dd Update journal-of-oil-palm-research.csl (#5403)
55f6eda Adds missing space after title and moves space from title prefix to author suffix. (#5407)
b5df1a8 Fixed Mendeley bug (#5411)
49530b4 Create the-journal-of-laryngology-and-otology.csl (#5410)
6d95f75 Create college-research-libraries.csl (#5406)
9876e81 Create biostatistics.csl (#5372)
673db49 Update revue-forestiere-francaise.csl (#5387)
474cc2e Create oil-shale.csl (#5389)
249ad6a Updating infoclio.ch styles (#5391)
6dc6742 Update ocean-and-coastal-research.csl (#5392)
1e75c74 Update and rename dependent/experimental-biology-and-medicine.csl to … (#5398)
0a072f8 Update universite-du-quebec-a-montreal.csl (#5399)
373d684 Create the-bovine-practitioner.csl (#5400)
cdbb6ed Create journal-of-oil-palm-research.csl (#5388)
a75cb35 Update south-african-medical-journal.csl (#5393)
a35360f Update journal-of-nutrition.csl (#5397)
ef215ac Update and rename journal-of-neurosurgery.csl to dependent/journal-of… (make AMA dependent) (#5359)
c435731 Create ocean-and-coastal-research.csl (#5364)
561024e Create istanbul-medical-journal.csl (#5374)
21ba5d8 Update aquatic-conservation.csl (#5379)
c83c4a9 Create endocrine-connections.csl (#5380)
7da88e9 Update society-of-biblical-literature-fullnote-bibliography.csl (#5381)
ca27bc1 Update university-of-york-harvard-environment.csl (#5384)
df54422 Update university-of-york-harvard-archaeology.csl (#5385)
4439cdd Create revue-forestiere-francaise.csl (#5386)
c363e8f Update catholic-biblical-association.csl (#5360)
7e383b8 Fix locators in PU Paris-Nanterre (#5376)
83cb249 Update methods-of-information-in-medicine.csl (#5370)
5b19db4 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5371)
27d116b Update harvard-cite-them-right-no-et-al.csl (#5373)
e2ef408 Update ageing-and-society.csl (#5375)
16098e4 Update triangle.csl (#5369)
133d633 Create university-of-tasmania-simplified-author-date.csl (#5357)
b9ecf07 Update revue-archeologique.csl (#5366)
6152cce Update journal-of-consumer-research.csl (#5358)
93f6600 Create refugee-survey-quarterly.csl (#5354)
bfa3b6d Update canadian-biosystems-engineering.csl (#5362)
53e75ee update doi prefix (#5361)
5b3de98 Create archives-of-hand-and-microsurgery.csl (#5363)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: a3706b1
Siedlerchr pushed a commit that referenced this pull request Jun 16, 2021
@koppor
[Bot] Update CSL styles (#7824)
e55bf0a 
* Squashed 'buildres/csl/csl-styles/' changes from e1acabe..a3706b1

a3706b1 Fix ArchéoSciences (#5506)
daeadd3 Update hawaii-international-conference-on-system-sciences-proceedings… (#5505)
225b9c0 Create saglik-bilimleri-universitesi.csl (#5295)
7205734 Create health-education-england-harvard-citation-style.csl (#5345)
b2085cb Adicionar ponto e espaço antes de "Disponível em:" (#5367)
f3eb50a Create apa6-for-international-journal-of-learner-corpus-research.csl (#5430)
ff34f5c Update fachhochschule-vorarlberg-note.csl (#5502)
5aa48f7 Update fachhochschule-vorarlberg-author-date.csl (#5501)
717fba3 Create apa6-for-register-studies.csl (#5458)
147689b Update food-and-agriculture-organization-of-the-united-nations.csl  (#5492)
e35ae39 New citation style: "Norsk henvisningsstandard for rettsvitenskapelige tekster" (validated) (#5494)
7ff9389 revise Manchester Univ. Press style (note-bib) (#5500)
9e97809 move citation number outside first field (#5499)
b08e5d7 Update APA disambiguation rules to only initials (#5498)
5d1629f Create arbok-hins-islenzka-fornleifafelags.csl (#5497)
3a2ff5f Create novasinergia.csl (#5489)
35920e2 Update din-1505-2.csl (#5491)
197486e Create zeitschrift-fuer-fantastikforschung.csl (#5490)
2cd6364 Create artificial-organs.csl (#5340)
5ea7955 Create society-of-biblical-literature-1st-edition-fullnote-bibliography (#5421)
d0de451 Create Journal of Move and Therapeutic Science (#5486)
899c2bc Update ACS documentation & date format
950f730 Create ulua-revista-de-historia-sociedad-y-cultura.csl (#5478)
a1c34f5 Update wirtschaftsuniversitat-wien-institut-fur-bwl-des-aussenhandels.csl (#5470)
79fa66e Update gallia-prehistoire.csl (#5467)
2f1df12 Update hochschule-bonn-rhein-sieg.csl (#5479)
06078c6 Update acta-universitatis-agriculturae-sueciae.csl (#5409)
3650206 Update ethnographiques-org.csl (#5480)
e06cc90 remove et-al from restoration-ecology.csl (#5485)
4e4e1f3 Presses universitaires de Strasbourg – Fix op.cit and multiple items (#5484)
f8ff160 Create UWE-Bristol-Harvard-2021.csl (#5482)
10a1d17 Fix authors delimiter (#5483)
f53ff57 Update stuttgart-media-university.csl (#5477)
c7a01e0 Create worlds-veterinary-journal.csl (#5468)
ec923b2 Update experimental-biology-and-medicine.csl (#5469)
1d48cb7 Create plant-species-biology.csl (#5471)
ea68765 Create ethnographiques-org.csl (#5472)
0e1c470 Update harvard-bournemouth-university.csl (#5476)
96e8114 Use date issued in web documents if exists (#5418)
8377ec8 Create bibliothecae-it.csl (#5440)
a5707e7 Create bppb.csl (#5452)
dc0e509 Create babesch-annual-papers-on-mediterranean-archaeology.csl (#5424)
62aa816 Bump nokogiri from 1.11.1 to 1.11.4 (#5460)
47a603c Update society-of-biblical-literature-fullnote-bibliography.csl (#5436)
1de799b SAA: Update disambiguation
46da8c6 Update iso690-author-date-cs.csl (#5443)
2a74991 Exempt ISSNs for Topoi journal (#5444)
a0f3130 show test directories
f9ce567 Updates ( -> [ (#5347)
c3910dd IEEE.csl - Add "I. Online Video (e.g., YouTube)" (#5365)
d37f39a Update estudios-hispanicos.csl (#5417)
931c057 Create topoi-orient-occident-classique.csl (#5427)
70ee747 Create topoi-orient-occident-auteur-date.csl (#5426)
8ea5ed2 Update universite-de-montreal-apa.csl (#5428)
f0dcb04 Update the-horticulture-journal.csl (#5437)
767df6d Update transnational-environmental-law.csl (#5435)
1e63dfe Update environmental-values.csl to match requirements (#5355)
94163d8 Create studies-in-the-history-of-gardens-and-designed-landscapes.csl (#5425)
21dd881 Create journal-of-stroke.csl (#5429)
937ce4b Update the-plant-genome.csl (#5432)
996e217 Update springer-basic-author-date-no-et-al.csl (#5431)
7dd1f44 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5433)
141be9b Update civilta-italiana.csl (#5434)
10b2222 small fixes for jopr.csl (#5422)
bf59a9f Create jci-insight.csl (#5423)
9aebd58 Update mammalia.csl (#5404)
77dcd74 Update gost-r-7-0-5-2008 styles (#5412)
5d348dd Update journal-of-oil-palm-research.csl (#5403)
55f6eda Adds missing space after title and moves space from title prefix to author suffix. (#5407)
b5df1a8 Fixed Mendeley bug (#5411)
49530b4 Create the-journal-of-laryngology-and-otology.csl (#5410)
6d95f75 Create college-research-libraries.csl (#5406)
9876e81 Create biostatistics.csl (#5372)
673db49 Update revue-forestiere-francaise.csl (#5387)
474cc2e Create oil-shale.csl (#5389)
249ad6a Updating infoclio.ch styles (#5391)
6dc6742 Update ocean-and-coastal-research.csl (#5392)
1e75c74 Update and rename dependent/experimental-biology-and-medicine.csl to … (#5398)
0a072f8 Update universite-du-quebec-a-montreal.csl (#5399)
373d684 Create the-bovine-practitioner.csl (#5400)
cdbb6ed Create journal-of-oil-palm-research.csl (#5388)
a75cb35 Update south-african-medical-journal.csl (#5393)
a35360f Update journal-of-nutrition.csl (#5397)
ef215ac Update and rename journal-of-neurosurgery.csl to dependent/journal-of… (make AMA dependent) (#5359)
c435731 Create ocean-and-coastal-research.csl (#5364)
561024e Create istanbul-medical-journal.csl (#5374)
21ba5d8 Update aquatic-conservation.csl (#5379)
c83c4a9 Create endocrine-connections.csl (#5380)
7da88e9 Update society-of-biblical-literature-fullnote-bibliography.csl (#5381)
ca27bc1 Update university-of-york-harvard-environment.csl (#5384)
df54422 Update university-of-york-harvard-archaeology.csl (#5385)
4439cdd Create revue-forestiere-francaise.csl (#5386)
c363e8f Update catholic-biblical-association.csl (#5360)
7e383b8 Fix locators in PU Paris-Nanterre (#5376)
83cb249 Update methods-of-information-in-medicine.csl (#5370)
5b19db4 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5371)
27d116b Update harvard-cite-them-right-no-et-al.csl (#5373)
e2ef408 Update ageing-and-society.csl (#5375)
16098e4 Update triangle.csl (#5369)
133d633 Create university-of-tasmania-simplified-author-date.csl (#5357)
b9ecf07 Update revue-archeologique.csl (#5366)
6152cce Update journal-of-consumer-research.csl (#5358)
93f6600 Create refugee-survey-quarterly.csl (#5354)
bfa3b6d Update canadian-biosystems-engineering.csl (#5362)
53e75ee update doi prefix (#5361)
5b3de98 Create archives-of-hand-and-microsurgery.csl (#5363)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: a3706b1

* Squashed 'buildres/csl/csl-locales/' changes from 79c4dba80a..bd8d2dbc85

bd8d2dbc85 Update spec_helper for pull-request testing (#220)
ed3fc7c9be Update to Ruby 3.0.0 (#218)

git-subtree-dir: buildres/csl/csl-locales
git-subtree-split: bd8d2dbc85713b192d426fb02749475df30f0d2c

Co-authored-by: github actions <[email protected]>
koppor pushed a commit that referenced this pull request Jul 1, 2021
Squashed 'buildres/csl/csl-styles/' changes from e1acabe..36ba508
04a2d19 
36ba508 Update civilta-italiana.csl (#5531)
3ea7d02 Only "page" locators are ommited in book citations in JuS journal. (#5532)
1851a54 Create alternatif-politika.csl (#5527)
f30aadb [norsk-henvisningsstandard] Fix wrong article title prefix (period to comma) (#5529)
e2f404e PAIN: Remove book pages&label
b483372 Create urad-za-makroekonomske-analize-in-razvoj.csl (#5520)
76ac3d7 Bugfixes and improvements to the handling of the editors term for norsk-henvisningsstandard-for-rettsvitenskepelige-tekster.csl. (#5515)
afe5685 Create monograph-of-the-palaeontographical-society.csl (#5521)
03d40ad Create stellenbosch-university-harvard-2021.csl (#5524)
1112d83 Update ios-press-books.csl (#5522)
5e5957d Create wirtschaftsuniversitat-wien-institut-fur-transportwirtschaft-u… (#5419)
fb9fe50 update acta hydrotechnica (#5525)
c576359 Patch 4 (#5510)
a46174d Create social-anthropology.csl (#5512)
a91627c Create orthopaedic-journal-of-sports-medicine.csl (#5511)
315fd4c Create fundamental-and-applied-limnology.csl (#5514)
f4b3327 Create acta-hydrotechnica.csl (#5516)
ff9b2b5 Update ocean-and-coastal-research.csl (#5517)
52f9d99 Improvements to norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5507)
a3706b1 Fix ArchéoSciences (#5506)
daeadd3 Update hawaii-international-conference-on-system-sciences-proceedings… (#5505)
225b9c0 Create saglik-bilimleri-universitesi.csl (#5295)
7205734 Create health-education-england-harvard-citation-style.csl (#5345)
b2085cb Adicionar ponto e espaço antes de "Disponível em:" (#5367)
f3eb50a Create apa6-for-international-journal-of-learner-corpus-research.csl (#5430)
ff34f5c Update fachhochschule-vorarlberg-note.csl (#5502)
5aa48f7 Update fachhochschule-vorarlberg-author-date.csl (#5501)
717fba3 Create apa6-for-register-studies.csl (#5458)
147689b Update food-and-agriculture-organization-of-the-united-nations.csl  (#5492)
e35ae39 New citation style: "Norsk henvisningsstandard for rettsvitenskapelige tekster" (validated) (#5494)
7ff9389 revise Manchester Univ. Press style (note-bib) (#5500)
9e97809 move citation number outside first field (#5499)
b08e5d7 Update APA disambiguation rules to only initials (#5498)
5d1629f Create arbok-hins-islenzka-fornleifafelags.csl (#5497)
3a2ff5f Create novasinergia.csl (#5489)
35920e2 Update din-1505-2.csl (#5491)
197486e Create zeitschrift-fuer-fantastikforschung.csl (#5490)
2cd6364 Create artificial-organs.csl (#5340)
5ea7955 Create society-of-biblical-literature-1st-edition-fullnote-bibliography (#5421)
d0de451 Create Journal of Move and Therapeutic Science (#5486)
899c2bc Update ACS documentation & date format
950f730 Create ulua-revista-de-historia-sociedad-y-cultura.csl (#5478)
a1c34f5 Update wirtschaftsuniversitat-wien-institut-fur-bwl-des-aussenhandels.csl (#5470)
79fa66e Update gallia-prehistoire.csl (#5467)
2f1df12 Update hochschule-bonn-rhein-sieg.csl (#5479)
06078c6 Update acta-universitatis-agriculturae-sueciae.csl (#5409)
3650206 Update ethnographiques-org.csl (#5480)
e06cc90 remove et-al from restoration-ecology.csl (#5485)
4e4e1f3 Presses universitaires de Strasbourg – Fix op.cit and multiple items (#5484)
f8ff160 Create UWE-Bristol-Harvard-2021.csl (#5482)
10a1d17 Fix authors delimiter (#5483)
f53ff57 Update stuttgart-media-university.csl (#5477)
c7a01e0 Create worlds-veterinary-journal.csl (#5468)
ec923b2 Update experimental-biology-and-medicine.csl (#5469)
1d48cb7 Create plant-species-biology.csl (#5471)
ea68765 Create ethnographiques-org.csl (#5472)
0e1c470 Update harvard-bournemouth-university.csl (#5476)
96e8114 Use date issued in web documents if exists (#5418)
8377ec8 Create bibliothecae-it.csl (#5440)
a5707e7 Create bppb.csl (#5452)
dc0e509 Create babesch-annual-papers-on-mediterranean-archaeology.csl (#5424)
62aa816 Bump nokogiri from 1.11.1 to 1.11.4 (#5460)
47a603c Update society-of-biblical-literature-fullnote-bibliography.csl (#5436)
1de799b SAA: Update disambiguation
46da8c6 Update iso690-author-date-cs.csl (#5443)
2a74991 Exempt ISSNs for Topoi journal (#5444)
a0f3130 show test directories
f9ce567 Updates ( -> [ (#5347)
c3910dd IEEE.csl - Add "I. Online Video (e.g., YouTube)" (#5365)
d37f39a Update estudios-hispanicos.csl (#5417)
931c057 Create topoi-orient-occident-classique.csl (#5427)
70ee747 Create topoi-orient-occident-auteur-date.csl (#5426)
8ea5ed2 Update universite-de-montreal-apa.csl (#5428)
f0dcb04 Update the-horticulture-journal.csl (#5437)
767df6d Update transnational-environmental-law.csl (#5435)
1e63dfe Update environmental-values.csl to match requirements (#5355)
94163d8 Create studies-in-the-history-of-gardens-and-designed-landscapes.csl (#5425)
21dd881 Create journal-of-stroke.csl (#5429)
937ce4b Update the-plant-genome.csl (#5432)
996e217 Update springer-basic-author-date-no-et-al.csl (#5431)
7dd1f44 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5433)
141be9b Update civilta-italiana.csl (#5434)
10b2222 small fixes for jopr.csl (#5422)
bf59a9f Create jci-insight.csl (#5423)
9aebd58 Update mammalia.csl (#5404)
77dcd74 Update gost-r-7-0-5-2008 styles (#5412)
5d348dd Update journal-of-oil-palm-research.csl (#5403)
55f6eda Adds missing space after title and moves space from title prefix to author suffix. (#5407)
b5df1a8 Fixed Mendeley bug (#5411)
49530b4 Create the-journal-of-laryngology-and-otology.csl (#5410)
6d95f75 Create college-research-libraries.csl (#5406)
9876e81 Create biostatistics.csl (#5372)
673db49 Update revue-forestiere-francaise.csl (#5387)
474cc2e Create oil-shale.csl (#5389)
249ad6a Updating infoclio.ch styles (#5391)
6dc6742 Update ocean-and-coastal-research.csl (#5392)
1e75c74 Update and rename dependent/experimental-biology-and-medicine.csl to … (#5398)
0a072f8 Update universite-du-quebec-a-montreal.csl (#5399)
373d684 Create the-bovine-practitioner.csl (#5400)
cdbb6ed Create journal-of-oil-palm-research.csl (#5388)
a75cb35 Update south-african-medical-journal.csl (#5393)
a35360f Update journal-of-nutrition.csl (#5397)
ef215ac Update and rename journal-of-neurosurgery.csl to dependent/journal-of… (make AMA dependent) (#5359)
c435731 Create ocean-and-coastal-research.csl (#5364)
561024e Create istanbul-medical-journal.csl (#5374)
21ba5d8 Update aquatic-conservation.csl (#5379)
c83c4a9 Create endocrine-connections.csl (#5380)
7da88e9 Update society-of-biblical-literature-fullnote-bibliography.csl (#5381)
ca27bc1 Update university-of-york-harvard-environment.csl (#5384)
df54422 Update university-of-york-harvard-archaeology.csl (#5385)
4439cdd Create revue-forestiere-francaise.csl (#5386)
c363e8f Update catholic-biblical-association.csl (#5360)
7e383b8 Fix locators in PU Paris-Nanterre (#5376)
83cb249 Update methods-of-information-in-medicine.csl (#5370)
5b19db4 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5371)
27d116b Update harvard-cite-them-right-no-et-al.csl (#5373)
e2ef408 Update ageing-and-society.csl (#5375)
16098e4 Update triangle.csl (#5369)
133d633 Create university-of-tasmania-simplified-author-date.csl (#5357)
b9ecf07 Update revue-archeologique.csl (#5366)
6152cce Update journal-of-consumer-research.csl (#5358)
93f6600 Create refugee-survey-quarterly.csl (#5354)
bfa3b6d Update canadian-biosystems-engineering.csl (#5362)
53e75ee update doi prefix (#5361)
5b3de98 Create archives-of-hand-and-microsurgery.csl (#5363)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 36ba508
Siedlerchr pushed a commit that referenced this pull request Jul 1, 2021
@koppor
[Bot] Update CSL styles (#7865)
de84abc 
* Squashed 'buildres/csl/csl-styles/' changes from e1acabe..36ba508

36ba508 Update civilta-italiana.csl (#5531)
3ea7d02 Only "page" locators are ommited in book citations in JuS journal. (#5532)
1851a54 Create alternatif-politika.csl (#5527)
f30aadb [norsk-henvisningsstandard] Fix wrong article title prefix (period to comma) (#5529)
e2f404e PAIN: Remove book pages&label
b483372 Create urad-za-makroekonomske-analize-in-razvoj.csl (#5520)
76ac3d7 Bugfixes and improvements to the handling of the editors term for norsk-henvisningsstandard-for-rettsvitenskepelige-tekster.csl. (#5515)
afe5685 Create monograph-of-the-palaeontographical-society.csl (#5521)
03d40ad Create stellenbosch-university-harvard-2021.csl (#5524)
1112d83 Update ios-press-books.csl (#5522)
5e5957d Create wirtschaftsuniversitat-wien-institut-fur-transportwirtschaft-u… (#5419)
fb9fe50 update acta hydrotechnica (#5525)
c576359 Patch 4 (#5510)
a46174d Create social-anthropology.csl (#5512)
a91627c Create orthopaedic-journal-of-sports-medicine.csl (#5511)
315fd4c Create fundamental-and-applied-limnology.csl (#5514)
f4b3327 Create acta-hydrotechnica.csl (#5516)
ff9b2b5 Update ocean-and-coastal-research.csl (#5517)
52f9d99 Improvements to norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5507)
a3706b1 Fix ArchéoSciences (#5506)
daeadd3 Update hawaii-international-conference-on-system-sciences-proceedings… (#5505)
225b9c0 Create saglik-bilimleri-universitesi.csl (#5295)
7205734 Create health-education-england-harvard-citation-style.csl (#5345)
b2085cb Adicionar ponto e espaço antes de "Disponível em:" (#5367)
f3eb50a Create apa6-for-international-journal-of-learner-corpus-research.csl (#5430)
ff34f5c Update fachhochschule-vorarlberg-note.csl (#5502)
5aa48f7 Update fachhochschule-vorarlberg-author-date.csl (#5501)
717fba3 Create apa6-for-register-studies.csl (#5458)
147689b Update food-and-agriculture-organization-of-the-united-nations.csl  (#5492)
e35ae39 New citation style: "Norsk henvisningsstandard for rettsvitenskapelige tekster" (validated) (#5494)
7ff9389 revise Manchester Univ. Press style (note-bib) (#5500)
9e97809 move citation number outside first field (#5499)
b08e5d7 Update APA disambiguation rules to only initials (#5498)
5d1629f Create arbok-hins-islenzka-fornleifafelags.csl (#5497)
3a2ff5f Create novasinergia.csl (#5489)
35920e2 Update din-1505-2.csl (#5491)
197486e Create zeitschrift-fuer-fantastikforschung.csl (#5490)
2cd6364 Create artificial-organs.csl (#5340)
5ea7955 Create society-of-biblical-literature-1st-edition-fullnote-bibliography (#5421)
d0de451 Create Journal of Move and Therapeutic Science (#5486)
899c2bc Update ACS documentation & date format
950f730 Create ulua-revista-de-historia-sociedad-y-cultura.csl (#5478)
a1c34f5 Update wirtschaftsuniversitat-wien-institut-fur-bwl-des-aussenhandels.csl (#5470)
79fa66e Update gallia-prehistoire.csl (#5467)
2f1df12 Update hochschule-bonn-rhein-sieg.csl (#5479)
06078c6 Update acta-universitatis-agriculturae-sueciae.csl (#5409)
3650206 Update ethnographiques-org.csl (#5480)
e06cc90 remove et-al from restoration-ecology.csl (#5485)
4e4e1f3 Presses universitaires de Strasbourg – Fix op.cit and multiple items (#5484)
f8ff160 Create UWE-Bristol-Harvard-2021.csl (#5482)
10a1d17 Fix authors delimiter (#5483)
f53ff57 Update stuttgart-media-university.csl (#5477)
c7a01e0 Create worlds-veterinary-journal.csl (#5468)
ec923b2 Update experimental-biology-and-medicine.csl (#5469)
1d48cb7 Create plant-species-biology.csl (#5471)
ea68765 Create ethnographiques-org.csl (#5472)
0e1c470 Update harvard-bournemouth-university.csl (#5476)
96e8114 Use date issued in web documents if exists (#5418)
8377ec8 Create bibliothecae-it.csl (#5440)
a5707e7 Create bppb.csl (#5452)
dc0e509 Create babesch-annual-papers-on-mediterranean-archaeology.csl (#5424)
62aa816 Bump nokogiri from 1.11.1 to 1.11.4 (#5460)
47a603c Update society-of-biblical-literature-fullnote-bibliography.csl (#5436)
1de799b SAA: Update disambiguation
46da8c6 Update iso690-author-date-cs.csl (#5443)
2a74991 Exempt ISSNs for Topoi journal (#5444)
a0f3130 show test directories
f9ce567 Updates ( -> [ (#5347)
c3910dd IEEE.csl - Add "I. Online Video (e.g., YouTube)" (#5365)
d37f39a Update estudios-hispanicos.csl (#5417)
931c057 Create topoi-orient-occident-classique.csl (#5427)
70ee747 Create topoi-orient-occident-auteur-date.csl (#5426)
8ea5ed2 Update universite-de-montreal-apa.csl (#5428)
f0dcb04 Update the-horticulture-journal.csl (#5437)
767df6d Update transnational-environmental-law.csl (#5435)
1e63dfe Update environmental-values.csl to match requirements (#5355)
94163d8 Create studies-in-the-history-of-gardens-and-designed-landscapes.csl (#5425)
21dd881 Create journal-of-stroke.csl (#5429)
937ce4b Update the-plant-genome.csl (#5432)
996e217 Update springer-basic-author-date-no-et-al.csl (#5431)
7dd1f44 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5433)
141be9b Update civilta-italiana.csl (#5434)
10b2222 small fixes for jopr.csl (#5422)
bf59a9f Create jci-insight.csl (#5423)
9aebd58 Update mammalia.csl (#5404)
77dcd74 Update gost-r-7-0-5-2008 styles (#5412)
5d348dd Update journal-of-oil-palm-research.csl (#5403)
55f6eda Adds missing space after title and moves space from title prefix to author suffix. (#5407)
b5df1a8 Fixed Mendeley bug (#5411)
49530b4 Create the-journal-of-laryngology-and-otology.csl (#5410)
6d95f75 Create college-research-libraries.csl (#5406)
9876e81 Create biostatistics.csl (#5372)
673db49 Update revue-forestiere-francaise.csl (#5387)
474cc2e Create oil-shale.csl (#5389)
249ad6a Updating infoclio.ch styles (#5391)
6dc6742 Update ocean-and-coastal-research.csl (#5392)
1e75c74 Update and rename dependent/experimental-biology-and-medicine.csl to … (#5398)
0a072f8 Update universite-du-quebec-a-montreal.csl (#5399)
373d684 Create the-bovine-practitioner.csl (#5400)
cdbb6ed Create journal-of-oil-palm-research.csl (#5388)
a75cb35 Update south-african-medical-journal.csl (#5393)
a35360f Update journal-of-nutrition.csl (#5397)
ef215ac Update and rename journal-of-neurosurgery.csl to dependent/journal-of… (make AMA dependent) (#5359)
c435731 Create ocean-and-coastal-research.csl (#5364)
561024e Create istanbul-medical-journal.csl (#5374)
21ba5d8 Update aquatic-conservation.csl (#5379)
c83c4a9 Create endocrine-connections.csl (#5380)
7da88e9 Update society-of-biblical-literature-fullnote-bibliography.csl (#5381)
ca27bc1 Update university-of-york-harvard-environment.csl (#5384)
df54422 Update university-of-york-harvard-archaeology.csl (#5385)
4439cdd Create revue-forestiere-francaise.csl (#5386)
c363e8f Update catholic-biblical-association.csl (#5360)
7e383b8 Fix locators in PU Paris-Nanterre (#5376)
83cb249 Update methods-of-information-in-medicine.csl (#5370)
5b19db4 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5371)
27d116b Update harvard-cite-them-right-no-et-al.csl (#5373)
e2ef408 Update ageing-and-society.csl (#5375)
16098e4 Update triangle.csl (#5369)
133d633 Create university-of-tasmania-simplified-author-date.csl (#5357)
b9ecf07 Update revue-archeologique.csl (#5366)
6152cce Update journal-of-consumer-research.csl (#5358)
93f6600 Create refugee-survey-quarterly.csl (#5354)
bfa3b6d Update canadian-biosystems-engineering.csl (#5362)
53e75ee update doi prefix (#5361)
5b3de98 Create archives-of-hand-and-microsurgery.csl (#5363)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 36ba508

* Squashed 'buildres/csl/csl-locales/' changes from 79c4dba80a..ec6d62a9e7

ec6d62a9e7 Merge pull request #231 from Pendzoncymisio/master
06c2693b7f Update locales-pl-PL.xml
75e95a1c92 Update of PL "accessed" translation
c6093128ac Update of PL "accessed" translation
bd8d2dbc85 Update spec_helper for pull-request testing (#220)
ed3fc7c9be Update to Ruby 3.0.0 (#218)

git-subtree-dir: buildres/csl/csl-locales
git-subtree-split: ec6d62a9e7c049001a55086a495022520989441c

Co-authored-by: github actions <[email protected]>
koppor pushed a commit that referenced this pull request Jul 4, 2021
Squashed 'buildres/csl/csl-styles/' changes from e1acabe..ec4a4c0
a832045 
ec4a4c0 Create rassegna-degli-archivi-di-stato.csl (#5530)
e3a4bb2 Update ocean-and-coastal-research.csl (#5533)
aeb3ece Create bakhtiniana-journal-of-discourse-studies.csl (#5535)
36ba508 Update civilta-italiana.csl (#5531)
3ea7d02 Only "page" locators are ommited in book citations in JuS journal. (#5532)
1851a54 Create alternatif-politika.csl (#5527)
f30aadb [norsk-henvisningsstandard] Fix wrong article title prefix (period to comma) (#5529)
e2f404e PAIN: Remove book pages&label
b483372 Create urad-za-makroekonomske-analize-in-razvoj.csl (#5520)
76ac3d7 Bugfixes and improvements to the handling of the editors term for norsk-henvisningsstandard-for-rettsvitenskepelige-tekster.csl. (#5515)
afe5685 Create monograph-of-the-palaeontographical-society.csl (#5521)
03d40ad Create stellenbosch-university-harvard-2021.csl (#5524)
1112d83 Update ios-press-books.csl (#5522)
5e5957d Create wirtschaftsuniversitat-wien-institut-fur-transportwirtschaft-u… (#5419)
fb9fe50 update acta hydrotechnica (#5525)
c576359 Patch 4 (#5510)
a46174d Create social-anthropology.csl (#5512)
a91627c Create orthopaedic-journal-of-sports-medicine.csl (#5511)
315fd4c Create fundamental-and-applied-limnology.csl (#5514)
f4b3327 Create acta-hydrotechnica.csl (#5516)
ff9b2b5 Update ocean-and-coastal-research.csl (#5517)
52f9d99 Improvements to norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5507)
a3706b1 Fix ArchéoSciences (#5506)
daeadd3 Update hawaii-international-conference-on-system-sciences-proceedings… (#5505)
225b9c0 Create saglik-bilimleri-universitesi.csl (#5295)
7205734 Create health-education-england-harvard-citation-style.csl (#5345)
b2085cb Adicionar ponto e espaço antes de "Disponível em:" (#5367)
f3eb50a Create apa6-for-international-journal-of-learner-corpus-research.csl (#5430)
ff34f5c Update fachhochschule-vorarlberg-note.csl (#5502)
5aa48f7 Update fachhochschule-vorarlberg-author-date.csl (#5501)
717fba3 Create apa6-for-register-studies.csl (#5458)
147689b Update food-and-agriculture-organization-of-the-united-nations.csl  (#5492)
e35ae39 New citation style: "Norsk henvisningsstandard for rettsvitenskapelige tekster" (validated) (#5494)
7ff9389 revise Manchester Univ. Press style (note-bib) (#5500)
9e97809 move citation number outside first field (#5499)
b08e5d7 Update APA disambiguation rules to only initials (#5498)
5d1629f Create arbok-hins-islenzka-fornleifafelags.csl (#5497)
3a2ff5f Create novasinergia.csl (#5489)
35920e2 Update din-1505-2.csl (#5491)
197486e Create zeitschrift-fuer-fantastikforschung.csl (#5490)
2cd6364 Create artificial-organs.csl (#5340)
5ea7955 Create society-of-biblical-literature-1st-edition-fullnote-bibliography (#5421)
d0de451 Create Journal of Move and Therapeutic Science (#5486)
899c2bc Update ACS documentation & date format
950f730 Create ulua-revista-de-historia-sociedad-y-cultura.csl (#5478)
a1c34f5 Update wirtschaftsuniversitat-wien-institut-fur-bwl-des-aussenhandels.csl (#5470)
79fa66e Update gallia-prehistoire.csl (#5467)
2f1df12 Update hochschule-bonn-rhein-sieg.csl (#5479)
06078c6 Update acta-universitatis-agriculturae-sueciae.csl (#5409)
3650206 Update ethnographiques-org.csl (#5480)
e06cc90 remove et-al from restoration-ecology.csl (#5485)
4e4e1f3 Presses universitaires de Strasbourg – Fix op.cit and multiple items (#5484)
f8ff160 Create UWE-Bristol-Harvard-2021.csl (#5482)
10a1d17 Fix authors delimiter (#5483)
f53ff57 Update stuttgart-media-university.csl (#5477)
c7a01e0 Create worlds-veterinary-journal.csl (#5468)
ec923b2 Update experimental-biology-and-medicine.csl (#5469)
1d48cb7 Create plant-species-biology.csl (#5471)
ea68765 Create ethnographiques-org.csl (#5472)
0e1c470 Update harvard-bournemouth-university.csl (#5476)
96e8114 Use date issued in web documents if exists (#5418)
8377ec8 Create bibliothecae-it.csl (#5440)
a5707e7 Create bppb.csl (#5452)
dc0e509 Create babesch-annual-papers-on-mediterranean-archaeology.csl (#5424)
62aa816 Bump nokogiri from 1.11.1 to 1.11.4 (#5460)
47a603c Update society-of-biblical-literature-fullnote-bibliography.csl (#5436)
1de799b SAA: Update disambiguation
46da8c6 Update iso690-author-date-cs.csl (#5443)
2a74991 Exempt ISSNs for Topoi journal (#5444)
a0f3130 show test directories
f9ce567 Updates ( -> [ (#5347)
c3910dd IEEE.csl - Add "I. Online Video (e.g., YouTube)" (#5365)
d37f39a Update estudios-hispanicos.csl (#5417)
931c057 Create topoi-orient-occident-classique.csl (#5427)
70ee747 Create topoi-orient-occident-auteur-date.csl (#5426)
8ea5ed2 Update universite-de-montreal-apa.csl (#5428)
f0dcb04 Update the-horticulture-journal.csl (#5437)
767df6d Update transnational-environmental-law.csl (#5435)
1e63dfe Update environmental-values.csl to match requirements (#5355)
94163d8 Create studies-in-the-history-of-gardens-and-designed-landscapes.csl (#5425)
21dd881 Create journal-of-stroke.csl (#5429)
937ce4b Update the-plant-genome.csl (#5432)
996e217 Update springer-basic-author-date-no-et-al.csl (#5431)
7dd1f44 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5433)
141be9b Update civilta-italiana.csl (#5434)
10b2222 small fixes for jopr.csl (#5422)
bf59a9f Create jci-insight.csl (#5423)
9aebd58 Update mammalia.csl (#5404)
77dcd74 Update gost-r-7-0-5-2008 styles (#5412)
5d348dd Update journal-of-oil-palm-research.csl (#5403)
55f6eda Adds missing space after title and moves space from title prefix to author suffix. (#5407)
b5df1a8 Fixed Mendeley bug (#5411)
49530b4 Create the-journal-of-laryngology-and-otology.csl (#5410)
6d95f75 Create college-research-libraries.csl (#5406)
9876e81 Create biostatistics.csl (#5372)
673db49 Update revue-forestiere-francaise.csl (#5387)
474cc2e Create oil-shale.csl (#5389)
249ad6a Updating infoclio.ch styles (#5391)
6dc6742 Update ocean-and-coastal-research.csl (#5392)
1e75c74 Update and rename dependent/experimental-biology-and-medicine.csl to … (#5398)
0a072f8 Update universite-du-quebec-a-montreal.csl (#5399)
373d684 Create the-bovine-practitioner.csl (#5400)
cdbb6ed Create journal-of-oil-palm-research.csl (#5388)
a75cb35 Update south-african-medical-journal.csl (#5393)
a35360f Update journal-of-nutrition.csl (#5397)
ef215ac Update and rename journal-of-neurosurgery.csl to dependent/journal-of… (make AMA dependent) (#5359)
c435731 Create ocean-and-coastal-research.csl (#5364)
561024e Create istanbul-medical-journal.csl (#5374)
21ba5d8 Update aquatic-conservation.csl (#5379)
c83c4a9 Create endocrine-connections.csl (#5380)
7da88e9 Update society-of-biblical-literature-fullnote-bibliography.csl (#5381)
ca27bc1 Update university-of-york-harvard-environment.csl (#5384)
df54422 Update university-of-york-harvard-archaeology.csl (#5385)
4439cdd Create revue-forestiere-francaise.csl (#5386)
c363e8f Update catholic-biblical-association.csl (#5360)
7e383b8 Fix locators in PU Paris-Nanterre (#5376)
83cb249 Update methods-of-information-in-medicine.csl (#5370)
5b19db4 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5371)
27d116b Update harvard-cite-them-right-no-et-al.csl (#5373)
e2ef408 Update ageing-and-society.csl (#5375)
16098e4 Update triangle.csl (#5369)
133d633 Create university-of-tasmania-simplified-author-date.csl (#5357)
b9ecf07 Update revue-archeologique.csl (#5366)
6152cce Update journal-of-consumer-research.csl (#5358)
93f6600 Create refugee-survey-quarterly.csl (#5354)
bfa3b6d Update canadian-biosystems-engineering.csl (#5362)
53e75ee update doi prefix (#5361)
5b3de98 Create archives-of-hand-and-microsurgery.csl (#5363)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: ec4a4c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez left review comments

@koppor koppor koppor left review comments

@LinusDietz LinusDietz LinusDietz approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoHaHu @koppor @tobiasdiez @Siedlerchr @LinusDietz