-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2772 issue fixed #3552
#2772 issue fixed #3552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks like a good start. However, it seems that you missed to change the string to FileExtensions in a few places. Eg, the build fails because of
/home/travis/build/JabRef/jabref/src/main/java/org/jabref/preferences/CustomExportList.java:93: error: incompatible types: String cannot be converted to FileExtensions
ExportFormat format = new ExportFormat(s.get(0), s.get(0), lfFileName, null, s.get(2), layoutPreferences,
okay, sorry i started travis again, i will fix it and will come back |
Good start, you should also take a look at the export dialog where the export formats are used to see if it can be changed there, too |
Changeed the string to FileExtensions at all places. |
How can i check in Travis where i broke the code ? |
@PJozeph Select one of the travis jobsm e.g. modernizer and click on it it out: |
@@ -20,22 +20,7 @@ | |||
import javax.xml.datatype.XMLGregorianCalendar; | |||
import javax.xml.namespace.QName; | |||
|
|||
import org.jabref.logic.importer.fileformat.bibtexml.Article; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem are these removed imports (and similarly further down)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont have org.jabref.logic.importer.fileformat.bibtexml folder
There is still a problem with the imports. try running |
In Eclipse you can run CTRL+Shift+O to organize your imports |
that's right,but since the project does not have org.jabref.logic.importer.fileformat.bibtexml folder the CTRL+Shift+O will remove those imports @Siedlerchr |
Then you have messed up sth. I will take a look at your branch |
Ah okay, you have an import name clash. If you simply remove the first import of java.io.File it should work again. (I tested it locally) |
I dont understand this. The ModsExportFormat and BibTeXMLExportFormat with full of compiler error there are many Classes that cannot be resolved. I still dont have org.jabref.logic.importer.fileformat.bibtexml package. Removed the first java.io.File in the ModsExportFormat and BibTeXMLExportFormat class but got the same issue. What i see after running ./gradlew check is that the build fails due to this compiler errors. |
I created a patch file which fixes the imports and your build: To import it, remove the .txt extension and do: |
This really looks like a problem with your setup. The code in question (bibtexml/...) is automatically generated if I'm not mistaken. Can you try to run |
i decided to rebuild the working environment. But the build failed and i got a exception as : Execution failed for task ':junitPlatformTest'.
|
Fixes #2772
gradle localizationUpdate
?