#2772 issue fixed

[PJozeph]

Fixes #2772

---

• Change in CHANGELOG.md described
• Tests created for changes
• Screenshots added (for bigger UI changes)
• Manually tested changed features in running JabRef
• Check documentation status (Issue created for outdated help page at help.jabref.org?)
• If you changed the localization: Did you run gradle localizationUpdate?

[tobiasdiez]

Thanks, this looks like a good start. However, it seems that you missed to change the string to FileExtensions in a few places. Eg, the build fails because of

/home/travis/build/JabRef/jabref/src/main/java/org/jabref/preferences/CustomExportList.java:93: error: incompatible types: String cannot be converted to FileExtensions

ExportFormat format = new ExportFormat(s.get(0), s.get(0), lfFileName, null, s.get(2), layoutPreferences,

[PJozeph]

okay, sorry i started travis again, i will fix it and will come back

[Siedlerchr]

Good start, you should also take a look at the export dialog where the export formats are used to see if it can be changed there, too

[PJozeph]

Changeed the string to FileExtensions at all places.

[PJozeph]

How can i check in Travis where i broke the code ?

[Siedlerchr]

@PJozeph Select one of the travis jobsm e.g. modernizer and click on it it out:
Seems like you forgot some pieces of code. Eclipse should have already warned you about build errors,
But the error log on travis looks odd. I restarted the job
https://travis-ci.org/JabRef/jabref/jobs/319061181

[tobiasdiez]

The problem are these removed imports (and similarly further down)

[PJozeph]

i dont have org.jabref.logic.importer.fileformat.bibtexml folder

[LinusDietz]

There is still a problem with the imports. try running ./gradlew check on your local computer to avoid the delay through travis

[Siedlerchr]

In Eclipse you can run CTRL+Shift+O to organize your imports

[PJozeph]

that's right,but since the project does not have org.jabref.logic.importer.fileformat.bibtexml folder the CTRL+Shift+O will remove those imports @Siedlerchr

[Siedlerchr]

Then you have messed up sth. I will take a look at your branch

[Siedlerchr]

Ah okay, you have an import name clash. If you simply remove the first import of java.io.File it should work again. (I tested it locally)

[PJozeph]

I dont understand this. The ModsExportFormat and BibTeXMLExportFormat with full of compiler error there are many Classes that cannot be resolved. I still dont have org.jabref.logic.importer.fileformat.bibtexml package.

Removed the first java.io.File in the ModsExportFormat and BibTeXMLExportFormat class but got the same issue.

What i see after running ./gradlew check is that the build fails due to this compiler errors.

t the same issue.

[PJozeph]

[Siedlerchr]

I created a patch file which fixes the imports and your build:
0004-fix-imports.patch.txt

To import it, remove the .txt extension and do:
git am < 0004-fix-imports.patch

[PJozeph]

unfortunately , no it does not

[tobiasdiez]

This really looks like a problem with your setup. The code in question (bibtexml/...) is automatically generated if I'm not mistaken. Can you try to run ./gradlew cleanEclipse, ./gradlew eclipse and ./gradlew generateSource?

[PJozeph]

i decided to rebuild the working environment. But the build failed and i got a exception as : Execution failed for task ':junitPlatformTest'.

Process 'command '/usr/lib/jvm/java-8-oracle/bin/java'' finished with non-zero exit value 1