-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExportFormats: Use FileExtension enum #2772
Comments
Can I have this issue ? @Siedlerchr |
@PJozeph sure! Let us know if you need help on the way (either ask here in this issue or open a PR with your preliminary code). |
okay, i'm on it |
Do I understood it right that in the ExportFormats class the EXPORT_FORMATS map needs to hold FileExtensions values ? @tobiasdiez |
Yes. The extension in
should not be a string but an instance of FileExtensions .
|
im done, is there a documentation how to proceed push ? I did not find it on wiki. @tobiasdiez |
Nice, that was quick! We have some general comments in https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md but in the end it boils down to the typical steps to contribute code: you push the changes to your own branch and create a pullrequest here on github. |
Implemented by #3565 |
Export Formats should use the FileExtensions Enum (analog to import), too
The text was updated successfully, but these errors were encountered: