Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExportFormats: Use FileExtension enum #2772

Closed
Siedlerchr opened this issue Apr 20, 2017 · 8 comments
Closed

ExportFormats: Use FileExtension enum #2772

Siedlerchr opened this issue Apr 20, 2017 · 8 comments
Labels
type: code-quality Issues related to code or architecture decisions

Comments

@Siedlerchr
Copy link
Member

Export Formats should use the FileExtensions Enum (analog to import), too

@Siedlerchr Siedlerchr added beginner type: code-quality Issues related to code or architecture decisions labels Apr 20, 2017
@PJozeph
Copy link
Contributor

PJozeph commented Dec 18, 2017

Can I have this issue ? @Siedlerchr

@tobiasdiez
Copy link
Member

@PJozeph sure! Let us know if you need help on the way (either ask here in this issue or open a PR with your preliminary code).

@PJozeph
Copy link
Contributor

PJozeph commented Dec 19, 2017

okay, i'm on it

@PJozeph
Copy link
Contributor

PJozeph commented Dec 19, 2017

Do I understood it right that in the ExportFormats class the EXPORT_FORMATS map needs to hold FileExtensions values ? @tobiasdiez

@tobiasdiez
Copy link
Member

Yes. The extension in ExportFormat


should not be a string but an instance of FileExtensions.

@PJozeph
Copy link
Contributor

PJozeph commented Dec 19, 2017

im done, is there a documentation how to proceed push ? I did not find it on wiki. @tobiasdiez

@tobiasdiez
Copy link
Member

Nice, that was quick! We have some general comments in https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md but in the end it boils down to the typical steps to contribute code: you push the changes to your own branch and create a pullrequest here on github.

This was referenced Dec 19, 2017
@tobiasdiez
Copy link
Member

Implemented by #3565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

No branches or pull requests

3 participants