Made possible to make the OO/LO panel a bit more narrow #1652
Conversation
oscargus
added
type: enhancement
ui
cleanup-ops
status: ready-for-review
| Object o = xSupplier.getReferenceMarks().getByName(name); | ||
| XNameAccess nameAccess = getReferenceMarks(); | ||
| if (nameAccess.hasByName(name)) { | ||
| Object o = nameAccess.getByName(name); |
There was a problem hiding this comment.
Possible to have a more speaking name for Object o?
There was a problem hiding this comment.
A more speaking name for the nameAcces, maybe xNamedRefMarks, or similar as in the getBookmarkRange method, would be nice, too.
There was a problem hiding this comment.
For sure it is possible. I just left it as is (and have no real idea what it does since I didn't consider that part of the code). While it looks like added code, it is just a consequence of the diff algorithm not really working.
There was a problem hiding this comment.
Ah okay. yeah, it looked like you changed it. If it is too much effort then leave it as is.
There was a problem hiding this comment.
There was a problem hiding this comment.
There are 111 hits for Object o. Some are probably OK as they are in equals, but it may be better to make a major overhaul for that issue.
There was a problem hiding this comment.
Okay, then I would suggest making this in a new PR.
There was a problem hiding this comment.
I updated most variable names that were a bit short in OOBibBase.
|
Just some minor remarks, rest looks good 👍 |
* master: Fixed OO/LO manual connection dialog on Linux Removed thrown Exception declarations (JabRef#1673) Fix JabRef#1288 Newly opened bib-file is not focused (JabRef#1671) Refactor DB loading Fix OutOfBoundsException when importing multiple entries in medline format (JabRef#1611) Removed the possibility to auto show or hide the groups interface (JabRef#1668) Add test to describe workaround for JabRef#1633 Fixed JabRef#1643: Searching with double quotes in a specific field ignores the last character fix build Fixes JabRef#1554: JabRefFrame is set as owner for ImportInspectionDialog Fixed most of the ErrorProne warnings Replaced output of getResolvedField to Optional<String> (JabRef#1650) PushToApplication cleanup and refactoring (JabRef#1659) Replaced Object with appropriate class where possible (JabRef#1660) Replaced some array return types (JabRef#1661) Fix XMP test Localization Moved the main part of XMPUtil to jabref.XMPUtilMain and injected a b… (JabRef#1642) Made possible to make the OO/LO panel a bit more narrow (JabRef#1652) French localization: Jabref_fr: empty strings + some cleaning
By using a shorter text for the button introduced in #1630 , it is possible to make it more narrow. Now, "OpenOffice/LibreOffice" is limiting the width.
Some small refactorings.