-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching for ( in specific fields #1633
Comments
The problem is that this is not detected as a grammar based search, but as a contains-based or simple search. You can circumvent the problem by searching for booktitle="(" which should work as expected. We could improve the search grammar, but this just takes too much time right now. Hence, I close this. |
OK! Didn't think of using "", but clearly that is a good (enough) approach! |
* master: Fixed OO/LO manual connection dialog on Linux Removed thrown Exception declarations (JabRef#1673) Fix JabRef#1288 Newly opened bib-file is not focused (JabRef#1671) Refactor DB loading Fix OutOfBoundsException when importing multiple entries in medline format (JabRef#1611) Removed the possibility to auto show or hide the groups interface (JabRef#1668) Add test to describe workaround for JabRef#1633 Fixed JabRef#1643: Searching with double quotes in a specific field ignores the last character fix build Fixes JabRef#1554: JabRefFrame is set as owner for ImportInspectionDialog Fixed most of the ErrorProne warnings Replaced output of getResolvedField to Optional<String> (JabRef#1650) PushToApplication cleanup and refactoring (JabRef#1659) Replaced Object with appropriate class where possible (JabRef#1660) Replaced some array return types (JabRef#1661) Fix XMP test Localization Moved the main part of XMPUtil to jabref.XMPUtilMain and injected a b… (JabRef#1642) Made possible to make the OO/LO panel a bit more narrow (JabRef#1652) French localization: Jabref_fr: empty strings + some cleaning
Although this is closed I post here as a user report as I think my experience is related to the “uncertain” search nomenclature that is required. Also related is issue #1505 regarding the apparent heterogeneous regex-regular expression implementation. IMHO being able to search reliably IS ESSENTIAL and of high priority for large database situation. Hover-over the search entry shows the full logic in words. This is a great feature, but doesn't seem to reflect what the help file suggest is should, not what Search seems to do. ""word1 and not word2"" selects all entries and highlights all those words including 'and' and 'not'. If I enter "word1 and not field2=word2"" eg: "flow and not memo=PhD" search totally fails with hover-over showing "... flowand and not and memo=PhD" It appears to not recognise the and, instead ignoring the space and adding it to the word, then inserting extra ands! I concluded the algorithm has be rewritten to look for Interestingly entrytype=Phdthesis where = means contains works Bracketing doesn't work at all as I expect from the help files with spaces before and after words changing the hover-over displayed meaning. I expect the problems identified are the different logic and regexpertise level of the programmers exacerbated by the limited help available. If so could this flag an upgrade of the help file with more extensive examples of multipart searches. |
An update to my previous post that is part of my confion and I think is a BUG. When searching for an expression it can be enclosed in Once you figure the crytic entry requirement it isn't a problem until you attempt to find something like LES. The issue is that LES also appears in words such as bubbles and coalescence. To avoid these you can use the spaces trick, however this then does not pick up first word field entry starting with LES. If all LES entries were capitals that would be the solution, but they are not always :-( What I really wanted was a way to specify keyword "LES" meaning just LES not ILES or LES boundary conditions. so using spaces to isolate a keyword is imperfect cludge. I have still to find how to search |
@ajbelle The issue of the last character disappearing was reported in #1643 and is claimed to be fixed in 2c9c7dd (with tests showing that it probably is). Have you tried version 3.6? The Although it is not solving what you are actually asking (searching the keywords field on a keyword by keyword basis rather than the complete field), I just want to point out the possibility to write something like From a code perspective adding special handling of the keywords field should be quite feasible, but I do not know how it will hurt performance. Would it make sense to introduce a pseudo-field I may have time to look at this in the near future, although the person with the best knowledge of the search system is having a break to finish his dissertation. We should probably have a look at the documentation as well, especially if these new things are introduced. |
@ajbelle Turned out that I just as well could add those lines right now. Please try it out at https://builds.jabref.org/bettersearch in a few minutes. Both However, when trying it I realized that |
Sorry, I was wrong about the discussion above regarding |
@ajbelle If you try out the very latest version I renamed these fields to
|
Thank you @oscargus your solution is brilliant. It all seems to be working as you say and I can now use |
I have a regular issue with https://builds.jabref.org/bettersearch crashing my Win7 box. The most consistent cause is editing something and then selecting the undo icon. There seems to be other situations, but I am never sure I have't pressed a key by mistake. This did not occur for me with ver3.6 |
Sorry to hear about your problem @ajbelle . My guess is that it is not directly related to the actual search PR, but to something else we have changed, but I will double check the code I added. Indeed, the help file should be improved, especially with good examples! |
Yes @oscargus I had no time to check what code change it may, but the undo capability for edit seems totally broken. Sorry for posting on your issue, it was simply the bettersearch build I downloaded. I am very impressed with your update (and from the behaviour do not think it is the cause). |
JabRef version: Latest developer
Search for e.g.
booktitle=(
without regex orbooktitle=\(
with regex. It seems like the parser does not find the field as it saysany field that contains booktitle=(
. Maybe a weird case, but I actually wanted to do that right now.Searching for
(
works well though.The text was updated successfully, but these errors were encountered: