Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #11938: Tab in empty text area field should focus the next field #12081

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Fix issue #11938: Tab in empty text area field should focus the next field #12081

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df8d955
Fix issue #11938: Tab in empty text area field should focus the next …
yeonissa Oct 22, 2024
d194344
Fix issue #11938: Tab in empty text area field should focus the next …
yeonissa Oct 22, 2024
fed50b2
Fix issue #11938: Tab in empty text area field should focus the next …
yeonissa Oct 24, 2024
8427705
Merge branch 'main' into fix-11938
yeonissa Oct 25, 2024
870f7cf
Merge branch 'main' into fix-11938
yeonissa Oct 26, 2024
d37f16b
Merge branch 'main' into fix-11938
yeonissa Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/org/jabref/gui/fieldeditors/EditorTextArea.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
import javafx.scene.control.ContextMenu;
import javafx.scene.control.MenuItem;
import javafx.scene.control.TextArea;
import javafx.scene.input.KeyCode;
import javafx.scene.input.KeyEvent;

import org.jabref.gui.ClipBoardManager;
import org.jabref.gui.fieldeditors.contextmenu.EditorContextAction;
Expand All @@ -27,6 +29,12 @@ public class EditorTextArea extends TextArea implements Initializable, ContextMe

public EditorTextArea() {
this("");
this.addEventFilter(KeyEvent.KEY_PRESSED, event -> {
if (event.getCode() == KeyCode.TAB && this.getText() != null && this.getText().isEmpty()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use JabRefs StringUtil.isEmpty(this.getText())

this.getParent().requestFocus();
event.consume();
}
});
}

public EditorTextArea(final String text) {
Expand Down
Loading