Fix issue #11938: Tab in empty text area field should focus the next field #12081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add event filter to move focus on TAB key press when TextArea is empty
koppor
added
ui
status: ready-for-review
koppor
requested changes
Oct 25, 2024
| @@ -26,7 +28,20 @@ public class EditorTextArea extends TextArea implements Initializable, ContextMe | |||
| }; | |||
|
|
|||
| public EditorTextArea() { | |||
| // Call the constructor with an empty string. | |||
There was a problem hiding this comment.
Remove comment - the code says it.
You can add a WHY to the comment. Why the empty string is passed. (If you know)
| this(""); | ||
|
|
||
| // Add an event filter to handle key press events |
There was a problem hiding this comment.
Remove comment, the code says it.
|
|
||
| // Add an event filter to handle key press events | ||
| this.addEventFilter(KeyEvent.KEY_PRESSED, event -> { | ||
| // If the TAB key is pressed and the TextArea is empty |
There was a problem hiding this comment.
Remove comment, the code says it.
| this.addEventFilter(KeyEvent.KEY_PRESSED, event -> { | ||
| // If the TAB key is pressed and the TextArea is empty | ||
| if (event.getCode() == KeyCode.TAB && this.getText().isEmpty()) { | ||
| // Move the focus to the next parent element (likely the next form field) |
There was a problem hiding this comment.
Remove comment, the code says it.
| // Move the focus to the next parent element (likely the next form field) | ||
| this.getParent().requestFocus(); | ||
|
|
||
| // Consume the event to prevent further processing of the TAB key |
There was a problem hiding this comment.
Remove comment, the code says it.
# remove comment
|
Hi @koppor, Thank you for the feedback! I've now removed the obvious code comments as suggested. |
7 tasks
koppor
requested changes
Oct 26, 2024
koppor
removed
the
status: ready-for-review
|
You also need to add a CHANGELOG.md entry - as soon as you really fixed the issue. |
# remove comment
koppor
reviewed
Oct 27, 2024
| @@ -27,6 +29,12 @@ public class EditorTextArea extends TextArea implements Initializable, ContextMe | |||
|
|
|||
| public EditorTextArea() { | |||
| this(""); | |||
| this.addEventFilter(KeyEvent.KEY_PRESSED, event -> { | |||
| if (event.getCode() == KeyCode.TAB && this.getText() != null && this.getText().isEmpty()) { | |||
There was a problem hiding this comment.
You can use JabRefs StringUtil.isEmpty(this.getText())
koppor
added
the
status: changes required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where pressing the Tab key in an empty text area should focus the next field, but it wasn't behaving as expected. The code change ensures that when the TextArea is empty, pressing the Tab key moves the focus to the next form field.
Closes #11938
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)