Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Improve the title bar #2561

Conversation

plvzfq-rit
Copy link

@plvzfq-rit plvzfq-rit commented Oct 8, 2024

🔗 Linked issue

Resolves #2518

📚 Description

  • Reworked the title bar such that the links above direct to sites that might be of interest (Docs, Forums, GitHub, etc.).
  • Removed some code that did not seem necessary for now like user profiles and the search bar (might add it back though should it become necessary) Readded these functionalities back
  • Some dropdown menus to the nav bar that shows some other links that users might find interesting (to Docs and Forums)
  • Add collapsible functionality to the title bar so that it is mobile responsive

Not really quite necessary, just a nice to have that could aid people going to the site in navigating to other places.

Previous title bar

image

Proposed title bar

image

New dropdowns

image

image

@tobiasdiez
Copy link
Member

Thanks!

Removed some code that did not seem necessary for now like user profiles and the search bar (might add it back though should it become necessary)

These are not shown on the main start page, but once you login they are shown (try the subpath /dashboard - but this section is a bit broken currently). So please don't remove these parts / readd them.

active-class="text-gray-400 hover:text-primary-600 text-lg font-semibold"
class="text-gray-400 hover:text-primary-600 text-lg font-semibold"
to="https://builds.jabref.org/"
>Builds</t-nuxtlink
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the nightly builds are that relevant.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I'll remove them then, much thanks+

@plvzfq-rit
Copy link
Author

I'll readd the functionalities back as soon as I could; apologies for that;;;

@plvzfq-rit plvzfq-rit marked this pull request as draft October 29, 2024 14:40
@plvzfq-rit plvzfq-rit marked this pull request as ready for review November 2, 2024 06:47
@plvzfq-rit
Copy link
Author

Readded the functionalities and changed out the nightly build with Gitter to partially help with issue #2562. Also made some of the menus dropdowns so that one could go farther.

Copy link

github-actions bot commented Nov 3, 2024

@tobiasdiez
Copy link
Member

Thanks a lot for your work @plvzfq-rit. I'm a bit undecided if I like the changes though. The menu was designed to be simple and give access to the most important links for new users. With these changes, there are now a lot of information that new users usually don't care about (they want to have an answer to 2 questions: is it worthwhile to install JabRef, and if so where can I download it).

@JabRef/developers what do you think?

@koppor
Copy link
Member

koppor commented Nov 8, 2024

Thanks a lot for your work @plvzfq-rit. I'm a bit undecided if I like the changes though. The menu was designed to be simple and give access to the most important links for new users. With these changes, there are now a lot of information that new users usually don't care about (they want to have an answer to 2 questions: is it worthwhile to install JabRef, and if so where can I download it).

@JabRef/developers what do you think?

I don't see any before/after screenshots nor any user stories. Hard to tell what I like more.

@plvzfq-rit
Copy link
Author

Hi @tobiasdiez, @koppor, I've added in a photo of the previous title bar and a photo of the new one; I've also included images of the new dropdowns as well. Apologies for not adding this in sooner

@Siedlerchr
Copy link
Member

I would simply add a new item "GitHub" in the existing title bar without changing the sizes etc

@koppor
Copy link
Member

koppor commented Nov 10, 2024

I would design it differently, too. The issue also asks for a GitHub-Button, too. Not a "portal".

Please focus on the new "GitHub" button - and fix #2176. That issue is the most urgent one!

@plvzfq-rit
Copy link
Author

Alright, I'll do just that; I'll close this pull request and focus on the other one which is more apt (#2560 ). I'll also have a look into #2176 . Thank you for y'all's generous input++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the title bar of main JabRef website
4 participants