-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add GitHub button to title bar #2560
base: main
Are you sure you want to change the base?
Conversation
Hi! I've added a GitHub logo button to the top right of the page in the title bar. I did not add a search bar for the title bar for now since the site is quite sparse. I also did not add a dark mode button since I was not sure how dark mode for the site should look like. Do let me know how I could improve upon this feature, or if there's something else I should do+ |
By the by, I am not quite sure if I could do this since I'm relatively new to doing open-source contributions, but I had sent parts of code from index.vue to ChatGPT since it was my first time working with Vue and I did not quite understand the code. I did try to delete what I had sent from its memory, as well as chat logs of the exchange. Apologies for this oversight;;; |
For now, I'll tinker with the code and see how else I could improve the title bar |
Would it be perhaps an idea to start by merging this PR first, and then work on the other improvements in another PR? Just let me know what you prefer! |
Oh, yeah, we could merge this in first before the other pull request+ I'll have this be ready for review then++ |
🔗 Linked issue
Resolves #2518
📚 Description
In this pull request, I add a title bar tab which links to the JabRef GitHub repositories.
Some breakpoint changes were also done to the JabRef name (from lg to xl) and to the detection of small screens (from md to lg); this was to fix an issue wherein the title bar appears below the divider when using smaller screens.
It makes navigation to the GitHub repositories easier.