Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GitHub button to title bar #2560

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

plvzfq-rit
Copy link

@plvzfq-rit plvzfq-rit commented Oct 6, 2024

🔗 Linked issue

Resolves #2518

📚 Description

image

image

image

In this pull request, I add a title bar tab which links to the JabRef GitHub repositories.
Some breakpoint changes were also done to the JabRef name (from lg to xl) and to the detection of small screens (from md to lg); this was to fix an issue wherein the title bar appears below the divider when using smaller screens.

It makes navigation to the GitHub repositories easier.

@plvzfq-rit
Copy link
Author

Hi! I've added a GitHub logo button to the top right of the page in the title bar. I did not add a search bar for the title bar for now since the site is quite sparse. I also did not add a dark mode button since I was not sure how dark mode for the site should look like. Do let me know how I could improve upon this feature, or if there's something else I should do+

@plvzfq-rit
Copy link
Author

By the by, I am not quite sure if I could do this since I'm relatively new to doing open-source contributions, but I had sent parts of code from index.vue to ChatGPT since it was my first time working with Vue and I did not quite understand the code. I did try to delete what I had sent from its memory, as well as chat logs of the exchange. Apologies for this oversight;;;

@plvzfq-rit
Copy link
Author

For now, I'll tinker with the code and see how else I could improve the title bar

@plvzfq-rit plvzfq-rit marked this pull request as draft October 7, 2024 13:15
@tobiasdiez
Copy link
Member

Would it be perhaps an idea to start by merging this PR first, and then work on the other improvements in another PR? Just let me know what you prefer!

@plvzfq-rit
Copy link
Author

Oh, yeah, we could merge this in first before the other pull request+ I'll have this be ready for review then++

@plvzfq-rit plvzfq-rit marked this pull request as ready for review October 11, 2024 11:00
Copy link

github-actions bot commented Oct 11, 2024

@plvzfq-rit
Copy link
Author

plvzfq-rit commented Nov 11, 2024

Hullo, I've made some changes in this pull request as suggested in #2561; these changes are updated in the first comment in this thread. Do let me know if I can make it better still. For now, as also suggested, I'll have a look into #2176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the title bar of main JabRef website
2 participants