Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVD Alerts v2.2.0 update - docs, sub opt for LAW, bug fixes #315 and #457 #6

Merged

Conversation

JCoreMS
Copy link
Owner

@JCoreMS JCoreMS commented Dec 18, 2024

Overview/Summary

Update to v2.2.0 includes documentation updates and bug fixes for issues Azure#315 and Azure#457 as well as a feature update to allow alternate subscription selection for Log Analytics resource.

This PR fixes/adds/changes/removes

  1. Issue [Question/Feedback]: How to enable AVD Pattern for multiple Host Pools and different Actions Groups? Azure/azure-monitor-baseline-alerts#315 resolved by appending the Action Group name with a random unique 13 characters to allow for subsequent deployments to not fail due to an existing Action Group with the same name.
  2. Issue AVD pattern: deployment wizard bug with the "VM in Separate Resource Group" checked Azure/azure-monitor-baseline-alerts#457 resolved by ensuring UI Definition does not hide the AVD Resources Resource Group Selection when checking the option for VMs in separate Resource Groups.
  3. Added Warning text on first deployment page outlining the prerequisite permissions required.
  4. Additional Subscription selector for Log Analytics Workspace and Azure Files selection and created titled section for Log Analytics in UI

Breaking Changes

  1. N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Brunoga-MS and others added 30 commits November 29, 2024 15:50
- Updated corresponding documentation
Property name case consistency and remediation script rename
New release documentation for 2024-12-10
AVD Alerts - Alert for Host Pool Capacity would not fire
Fixing bug from Steve DiStefano
Fixing logic for assigning value to MG
Reordering to put MG names all together
Setting platform MG to be visible only if need Hybrid and/or Azure VM
Renaming function for scope clarification
@JCoreMS JCoreMS merged commit cec5af9 into JCore-AVD_Alerts_Fix_Dec2024 Dec 18, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants