This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
az_recorder_20240905_181705.mp4 |
ILIYANGERMANOV
suggested changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@priyatanu a few notes:
- Let's not update the CategoryRepo usages in the backup usacase because it seems too dangerous
- Let's update CategoryDao -> CategoryRepo on all other places in the app
val list = mutableListOf<Category>() | ||
categoryList.filter { either -> | ||
when(either){ | ||
is Either.Left -> { error("Failed to insert data to db")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will crash the app! We don't want such behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. reverted
Also the dao layer deals with entity classes while repo layer deals with domain classes |
priyatanu
force-pushed
the
fix-issue-2962
branch
from
September 9, 2024 16:11
13be8a0
to
ec08752
Compare
github-actions
bot
added
the
Stale
No activity, will be automatically closed soon.
label
Sep 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
requested changes
Changes are needed. Please, apply them
Stale
No activity, will be automatically closed soon.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
What's changed?
Describe with a few bullets what's new:
-I've fixed technical debt from the code
Risk factors
What may go wrong if we merge your PR?
In what cases won't your code work?
Does this PR close any GitHub issues? (do not delete)
CategoryRepository
#2962Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.