Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

[Data Layer] Migrate the code to use the new the CategoryRepository #2962

Closed
1 task done
ILIYANGERMANOV opened this issue Feb 14, 2024 · 8 comments · Fixed by #3583
Closed
1 task done

[Data Layer] Migrate the code to use the new the CategoryRepository #2962

ILIYANGERMANOV opened this issue Feb 14, 2024 · 8 comments · Fixed by #3583
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev devexp Codebase & dev experience help wanted Help us! Appreciated keep Keep it from automatically getting closed by Stale P1 Important but can wait tech debt Legacy code that needs to be migrated

Comments

@ILIYANGERMANOV
Copy link
Collaborator

Please confirm the following

What would you like to improve?

  • Utilize CategoryRepository for data manipulation operations
  • Transition from direct CategoryDao and WriteCategoryDao interactions to using the repository

Because...

  • To phase out the old data management system
  • To maintain uniformity in our architectural approach
  • To enhance safety and facilitate ease of future extensions

Description

No response

Success Criteria

  • Comprehensive unit testing
  • Seamless operation of existing functionalities without regressions
  • Stable application functionality with the integrated new data layer
@ILIYANGERMANOV ILIYANGERMANOV added devexp Codebase & dev experience help wanted Help us! Appreciated approved Approved by the Ivy Wallet team. Ready for dev tech debt Legacy code that needs to be migrated keep Keep it from automatically getting closed by Stale P1 Important but can wait labels Feb 14, 2024
@ivywallet
Copy link
Collaborator

Thank you @ILIYANGERMANOV for raising Issue #2962! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@ILIYANGERMANOV ILIYANGERMANOV changed the title [Data Layer] Migrate the code to use the new the AccountRepository [Data Layer] Migrate the code to use the new the CategoryRepository Feb 14, 2024
@diasmashikov
Copy link
Contributor

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @diasmashikov! 🎉
Issue #2962 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

@priyatanu
Copy link
Contributor

I would like to work on it

@ILIYANGERMANOV
Copy link
Collaborator Author

https://github.com/Ivy-Apps/ivy-wallet/blob/main/CONTRIBUTING.md

@priyatanu
Copy link
Contributor

I am on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @priyatanu! 🎉
Issue #2962 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

@ILIYANGERMANOV
Copy link
Collaborator Author

@priyatanu are all usages of CategoryDao and WriteCategoryDao outside the data layer migrated to the repo?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Approved by the Ivy Wallet team. Ready for dev devexp Codebase & dev experience help wanted Help us! Appreciated keep Keep it from automatically getting closed by Stale P1 Important but can wait tech debt Legacy code that needs to be migrated
Projects
None yet
4 participants