Add image loading (to fix breaking tests on Drupal 9.4.x). #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosiel
changed the title
|
Closing, my approach was wrong. The ticket is solved by #869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#2093
What does this Pull Request do?
Tries to correct for the new image formatter setting by supplying it in the functional tests.
What's new?
This now passes the "image_loading" parameter. Hopefully it won't break on 9.3.x where this feature isn't available.
How should this be tested?
If the tests all pass, then this worked.
Documentation Status
Additional Notes:
Interested parties
@Islandora/8-x-committers