Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IIIF Manifest title from source entity #869

Merged
merged 7 commits into from
May 20, 2022
Merged

Set IIIF Manifest title from source entity #869

merged 7 commits into from
May 20, 2022

Conversation

alxp
Copy link

@alxp alxp commented May 2, 2022

What does this Pull Request do?

Changes default title of IIIF Manifest view from "IIIF Manifest" to the title of the node or media the manifest is generated from.

What's new?

Add a function to the IIIF Manifest view type that that gets the title of the node or media that the manifest represents.

If a user changes the display title in the view settings that will be used instead.

How should this be tested?

  1. Enable islandora_mirador module.
  2. Create content as follows:: A Repository Item with model "Paged content"
  3. One or more Repository Items with type FIle
  4. Media for each Page items, of type Document, with a TIFF file attached.
  5. Go to node/[nid]/book-manifest. Observe the Label field contains the title of the Paged Content node.
  6. Optionally, Set the display Hint to Mirador and ensure the viewer displays the node title rather than "IIIF Manifest"

Documentation Status

  • Does this change existing behaviour that's currently documented?

No

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

Copy link
Member

@rosiel rosiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and it works. (But I can't merge, since I work with @alxp)

@jordandukart
Copy link
Member

jordandukart commented May 18, 2022

Can also confirm that via configuration inspector that changing the schema as it is should be sufficient. 👍 from me in that regard at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants