Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lock file for installation of code-server #198

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Use lock file for installation of code-server #198

merged 2 commits into from
Mar 21, 2022

Conversation

nigelgbanks
Copy link
Contributor

@nigelgbanks nigelgbanks commented Mar 16, 2022 •
edited
Loading

For issue #197

@nigelgbanks
Copy link
Contributor Author

Doing some testing locally, if goes well I'll also change the composer packages to use a lock file as well.

@nigelgbanks nigelgbanks force-pushed the issue-197-code-server-cache branch from 6c2016a to 56c5e86 Compare March 16, 2022 23:12
Use lock files to pin versions of dependencies
7e9353c 
For both:

- code-server
- composer
@nigelgbanks nigelgbanks force-pushed the issue-197-code-server-cache branch from 56c5e86 to 7e9353c Compare March 16, 2022 23:20
@nigelgbanks nigelgbanks marked this pull request as ready for review March 16, 2022 23:21
@nigelgbanks nigelgbanks requested a review from g7morris March 16, 2022 23:22
@nigelgbanks
Copy link
Contributor Author

nigelgbanks commented Mar 16, 2022 •
edited
Loading

This is ready to go and can be tested with the following:

docker run -it -p 8443:8443 -e CODE_SERVER_AUTHENTICATION=none islandora/code-server:77a0730aef1fc2deb4a196b6c300dae2d639e5aa

If you can then visit the IDE in the browser at http://localhost:8443, then it's working as intended.

Just wait for the build https://github.com/Islandora-Devops/isle-buildkit/runs/5583227772?check_suite_focus=true to finish first.

jefferya
jefferya approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@jefferya jefferya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On WSL 2 Unbuntu, container built and was able to load in the browser

docker run -it -p 8443:8443 -e CODE_SERVER_AUTHENTICATION=none islandora/code-server:77a0730aef1fc2deb4a196b6c300dae2d639e5aa

@nigelgbanks nigelgbanks merged commit a8abe5d into main Mar 21, 2022
@nigelgbanks nigelgbanks deleted the issue-197-code-server-cache branch March 21, 2022 21:11
@nigelgbanks nigelgbanks mentioned this pull request Mar 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferya jefferya jefferya approved these changes

@g7morris g7morris Awaiting requested review from g7morris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nigelgbanks @jefferya