Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache issue with the latest tag in the code-server image in versions after 1.0.0-alpha-12 #197

Closed
nigelgbanks opened this issue Mar 16, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@nigelgbanks
Copy link
Contributor

I think this is arising from building a bad case and then relying on the cache going forward of that bad release. At the moment we're not using a lock file or version for code-server when doing the calls to yarn to install it (the assumption is it would always pull the latest) but since we're not specifying the version in the docker file the version is tied to the last time the build was run and if it got cached or not.

@nigelgbanks nigelgbanks self-assigned this Mar 16, 2022
@nigelgbanks nigelgbanks added the bug Something isn't working label Mar 16, 2022
@ysuarez
Copy link

ysuarez commented Mar 23, 2022

@nigelgbanks chiming in from today's Islandora the tech call (March 23). We see that you had a related PR merged. Does it mean that this issue can be closed or are their things that still need to be addressed or tested?

@nigelgbanks
Copy link
Contributor Author

@ysuarez yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants