Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pdf.js library. #26

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Nov 18, 2022

What does this Pull Request do?

Includes pdf.js in the starter site.

This will make the pdf.js library available [edited to say: as part of the starter-site]. Currently when you create an ISLE site that uses the Starter Site, pdf.js is not available. The Playbook does currently install pdf.js on its own, so a PR will follow to remove that.

  • Related GitHub Issue: Reported by @nigelgbanks

  • Other Relevant Links: (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What's new?

  • List pdf.js as a package, similar to the install profile.

  • Require it.

  • Does this change add any new dependencies? yes, it adds one that was missing!

  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no

  • Could this change impact execution of existing code? no

How should this be tested?

  • If you have a starter site on ISLE before this PR, notice it doesn't include pdf.js
  • Spin up a new starter site on ISLE with this PR. Create a PDF and see that it displays in the viewer.

Documentation Status

  • Does this change existing behaviour that's currently documented? ** no**
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? n/a
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag @nigelgbanks @adam-vessey

@nigelgbanks nigelgbanks merged commit 2b67316 into Islandora-Devops:main Nov 19, 2022
@nigelgbanks
Copy link
Contributor

Tested it locally works a treat.

@rosiel rosiel deleted the include-pdfjs branch November 21, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants