Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Includes pdf.js in the starter site.
This will make the pdf.js library available [edited to say: as part of the starter-site]. Currently when you create an ISLE site that uses the Starter Site, pdf.js is not available. The Playbook does currently install pdf.js on its own, so a PR will follow to remove that.
Related GitHub Issue: Reported by @nigelgbanks
Other Relevant Links: (Google Groups discussion, related pull requests,
Release pull requests, etc.)
What's new?
List pdf.js as a package, similar to the install profile.
Require it.
Does this change add any new dependencies? yes, it adds one that was missing!
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)? no
Could this change impact execution of existing code? no
How should this be tested?
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag @nigelgbanks @adam-vessey