Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-pdfjs #235

Merged
merged 2 commits into from
Nov 30, 2022
Merged

no-pdfjs #235

merged 2 commits into from
Nov 30, 2022

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Nov 28, 2022

GitHub Issue: (link)

What does this Pull Request do?

Now that both the Install Profile and the Starter Site include pdf.js in their composer.json, we don't have to install it in the playbook.

What's new?

  • Don't install pdfjs
  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

Spin up a site using starter or starter_dev, and test if pdfjs works.
Spin up a site using the install profile, and test if pdfjs works.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers

@seth-shaw-asu seth-shaw-asu self-requested a review November 30, 2022 18:24
@seth-shaw-asu seth-shaw-asu merged commit 6f4a2d4 into Islandora-Devops:dev Nov 30, 2022
@rosiel rosiel deleted the dev branch December 10, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants