Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberLiteral works properly when the decimal separator is not a dot #48

Merged

Conversation

davidnemeti
Copy link
Contributor

fixes #47

- QuickParse: fix the case when the NumberLiteral begins with a single digit immediately followed by the decimal separator (which is not a dot)
- ReadPrefix: fix the case when the NumberLiteral begins with the '0' digit immediately followed by the decimal separator (which is not a dot), and the "0" string is being registered as prefix for octal numbers
@yallie yallie merged commit ffee522 into IronyProject:master Jan 27, 2023
@yallie
Copy link
Member

yallie commented Jan 27, 2023

Thanks! 👍

@davidnemeti davidnemeti deleted the DecimalSeparator-fix-for-NumberLiteral branch January 27, 2023 15:09
davidnemeti added a commit to davidnemeti/Sarcasm that referenced this pull request Jan 27, 2023
…nuget package

Sarcasm uses Irony through a direct .NET Standard 2.0 dll file instead of a nuget package, until the following pull request are merged, and a new Irony nuget package is published:

IronyProject/Irony#46
IronyProject/Irony#48
IronyProject/Irony#50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumberLiteral should work properly when the decimal separator is not a dot
2 participants