Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate simpler parse tree for Kleene operator Q() #46

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Generate simpler parse tree for Kleene operator Q() #46

merged 2 commits into from
Jan 27, 2023

Conversation

davidnemeti
Copy link
Contributor

resolves #45

@yallie yallie merged commit f7a9c46 into IronyProject:master Jan 27, 2023
@yallie
Copy link
Member

yallie commented Jan 27, 2023

Hello @davidnemeti, thanks for your contributions! 👌
Please consider joining the IronyProject organization.
Cheers!

@davidnemeti davidnemeti deleted the generate-simpler-parse-tree-for-Kleene-operator-Q branch January 27, 2023 15:23
@davidnemeti
Copy link
Contributor Author

davidnemeti commented Jan 27, 2023 •
edited
Loading

Thanks, @yallie, I have accepted your kind invitation.

BTW, I am the author of Sarcasm which is a library for creating typesafe, domain-bound grammars, and it also has a grammar driven general unparser. (Sarcasm uses Irony, hence the name (pun intended 😄).) I am in the process of changing Sarcasm to be compatible with .NET (Core).

This "Kleene operator" change was crucial for Sarcasm, because without it unwanted shift-reduce conflicts would emerge for "if-else" rules in the grammar, if it is described in Sarcasm. So I am glad that you merged my pull request.

When do we publish a new nuget package of Irony?

davidnemeti added a commit to davidnemeti/Sarcasm that referenced this pull request Jan 27, 2023
@davidnemeti
using Irony through a direct .NET Standard 2.0 dll file instead of a …
4c764d3 
…nuget package

Sarcasm uses Irony through a direct .NET Standard 2.0 dll file instead of a nuget package, until the following pull request are merged, and a new Irony nuget package is published:

IronyProject/Irony#46
IronyProject/Irony#48
IronyProject/Irony#50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate simpler parse tree for Kleene operator Q()
2 participants
@davidnemeti @yallie