Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Fix the problem with pab-nami-demo psapigenerator #235 #241

Merged
3 commits merged into from
Jan 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 12, 2022

Fix #235.

Instead of providing a builtin PAB's psapigenerator, with #216 we encourage users to create their own small psapigenerators.

pab-nami-demo-generator is a small executable with only one purpose — to generate ps types for the DemoContract.


Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@ghost ghost requested review from silky, koslambrou and raduom January 12, 2022 09:39
@ghost ghost force-pushed the fix-pab-nami-demo-psapigenerator branch from 369f89d to b495cdb Compare January 12, 2022 10:34
@ghost ghost merged commit 21b592b into main Jan 12, 2022
@ghost ghost deleted the fix-pab-nami-demo-psapigenerator branch January 12, 2022 11:52
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing psapigenerator subcommand causes Nami wallet demo test to fail.
2 participants