Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated block-size #4775

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Updated block-size #4775

merged 2 commits into from
Jan 12, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Jan 12, 2024 •
edited
Loading

Description

  • ouroboros-network: increased block-size in ingress size calculations
  • ouroboros-network: use correct size prefixes units

Requires #4774.

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@coot coot added the block-fetch Issues related to block fetch component. label Jan 12, 2024
@coot coot self-assigned this Jan 12, 2024
@coot coot requested a review from karknu January 12, 2024 11:40
@coot coot marked this pull request as ready for review January 12, 2024 11:40
karknu
karknu approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@coot coot added this pull request to the merge queue Jan 12, 2024
Merged via the queue into master with commit 5df93dc Jan 12, 2024
9 of 10 checks passed
@coot coot deleted the coot/block-size branch January 12, 2024 14:47
@coot coot changed the title Update block-size Updated block-size Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karknu karknu karknu approved these changes

Assignees

@coot coot

Labels
block-fetch Issues related to block fetch component.
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coot @karknu