Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MiniProtocolParameters: Change pipelining types to Word16 #4774

Merged
merged 1 commit into from
Jan 12, 2024
Merged

MiniProtocolParameters: Change pipelining types to Word16 #4774

merged 1 commit into from
Jan 12, 2024

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Jan 12, 2024

Follow on from 8258206.

Description MiniProtocolParameters: Change pipelining types to Word16

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@erikd erikd requested a review from coot as a code owner January 12, 2024 03:23
@erikd erikd self-assigned this Jan 12, 2024
@erikd erikd force-pushed the erikd/mini-proto-params branch 2 times, most recently from f7c34ea to 1860026 Compare January 12, 2024 09:29
coot
coot approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

karknu
karknu approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@coot coot enabled auto-merge January 12, 2024 10:14
@coot coot mentioned this pull request Jan 12, 2024
Merged
9 tasks
@coot coot added this pull request to the merge queue Jan 12, 2024
Merged via the queue into master with commit fb7e5d4 Jan 12, 2024
9 of 10 checks passed
@coot coot deleted the erikd/mini-proto-params branch January 12, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karknu karknu karknu approved these changes

@coot coot coot approved these changes

Assignees

@erikd erikd

Labels
None yet
Projects
Ouroboros Network
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikd @coot @karknu