DONTMERGE: Add consensus to Windows CI #1851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
force-pushed
the
mrBliss/consensus-windows-ci
branch
2 times, most recently
from
eaa4b55 to
c2a8e3a
Compare
mrBliss
changed the title
|
Waiting on #1852. |
mrBliss
force-pushed
the
mrBliss/consensus-windows-ci
branch
from
c2a8e3a to
1ce97e8
Compare
|
CI passes, hurray! Adding consensus to CI increases the run-time from ~17 min to ~44 min 🙁. I think some better caching would improve things:
I would expect that "Configure Chocolatey", "Install msys2", and "Install GHC" can be cached. Moreover, I have highlighted some steps that really should benefit from caching. We're building all our Finally, for all the four Is that correct? It seems like it is not caching things. |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 26, 2020
1855: Hard-code expected results as CBOR for golden files instead of using files r=mrBliss a=mrBliss Fixes #1351. Using files to store the expected results for golden files, and thus relative paths, was a PITA: see #1351 + it was causing problems in #1851. This PR introduces `Test.Util.Golden`, which takes the expected result as a CBOR `FlatTerm`. No more files, hurray! Using a `FlatTerm` will make diffing much easier. Co-authored-by: Thomas Winant <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Mar 26, 2020
1855: Hard-code expected results as CBOR for golden files instead of using files r=mrBliss a=mrBliss Fixes #1351. Using files to store the expected results for golden files, and thus relative paths, was a PITA: see #1351 + it was causing problems in #1851. This PR introduces `Test.Util.Golden`, which takes the expected result as a CBOR `FlatTerm`. No more files, hurray! Using a `FlatTerm` will make diffing much easier. Co-authored-by: Thomas Winant <[email protected]>
Fixes #1847.
This makes the tests super slow and should only be enabled on a nightly CI job.
mrBliss
force-pushed
the
mrBliss/consensus-windows-ci
branch
from
1ce97e8 to
760f908
Compare
|
I think this one is no longer applicable? CC: @coot |
|
Yes, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes IntersectMBO/ouroboros-consensus#697.