Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and test consensus on real Windows in CI #697

Closed
mrBliss opened this issue Mar 25, 2020 · 2 comments
Closed

Build and test consensus on real Windows in CI #697

mrBliss opened this issue Mar 25, 2020 · 2 comments
Labels
continuous integration 🗑️ ❓ possibly stale

Comments

@mrBliss
Copy link
Contributor

mrBliss commented Mar 25, 2020

Splitting off from IntersectMBO/ouroboros-network#1082:

Moreover, as of IntersectMBO/ouroboros-network#1835, CI builds and tests on Windows using Wine (mingw32), which gives us some confidence consensus works on Windows. cardano-node, which uses consensus, has been reported to run successfully on Windows.

I think the only thing left to do is: let CI build and test on Windows (real Windows, not using Wine). @coot has a PR open for this (#1808), when that's merged, we can simply add the consensus tests to it. At that point we'll notice any remaining Windows problems and it will also make sure we don't regress.
@mrBliss mrBliss mentioned this issue Mar 25, 2020
Closed
@dcoutts
Copy link
Contributor

dcoutts commented Mar 25, 2020

IntersectMBO/ouroboros-network#1808 is merged.

mrBliss referenced this issue in IntersectMBO/ouroboros-network Mar 25, 2020
@mrBliss
Add consensus to Windows CI
bc6e327 
Fixes #1847.
@mrBliss mrBliss mentioned this issue Mar 25, 2020
Closed
mrBliss referenced this issue in IntersectMBO/ouroboros-network Mar 25, 2020
@mrBliss
Add consensus to Windows CI
6b14e61 
Fixes #1847.
mrBliss referenced this issue in IntersectMBO/ouroboros-network Mar 26, 2020
@mrBliss
Add consensus to Windows CI
510f7f0 
Fixes #1847.
mrBliss referenced this issue in IntersectMBO/ouroboros-network Apr 23, 2020
@mrBliss
Add consensus to Windows CI
dfdcda6 
Fixes #1847.
@dnadales dnadales transferred this issue from IntersectMBO/ouroboros-network Dec 1, 2023
@dnadales dnadales moved this to 🔖 Ready in Consensus Team Backlog Dec 1, 2023
@jasagredo
Copy link
Contributor

As we don't have Windows specific behavior on consensus, we are not going to test in Windows in CI (except for nix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
continuous integration 🗑️ ❓ possibly stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DONTMERGE: Add consensus to Windows CI IntersectMBO/ouroboros-network
4 participants
@dnadales @mrBliss @dcoutts @jasagredo