Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate transactions in DualPBFT tests #1503

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Conversation

edsko
Copy link
Contributor

@edsko edsko commented Jan 24, 2020

No description provided.

@edsko
Copy link
Contributor Author

edsko commented Jan 27, 2020

IntersectMBO/cardano-ledger#1177 should be merged first, but other than that, I think this is mostly ready. We might want to add some labelling to make sure we don't produce non-empty blocks though :)

@edsko edsko marked this pull request as ready for review January 27, 2020 17:11
@edsko edsko force-pushed the edsko/generate-byron-txs branch 3 times, most recently from 890d074 to a0ae123 Compare January 27, 2020 18:23
@edsko
Copy link
Contributor Author

edsko commented Jan 27, 2020

Ok, added the labelling. For the DualPBFT tests we get

      average #txs/block (100 in total):
      77% R_Btwn (5.0,10.0)
      16% R_Eq 0.0
       3% R_Btwn (10.0,20.0)
       2% R_Btwn (4.0,5.0)
       1% R_Btwn (1.0,2.0)
       1% R_Eq 2.0

The only problem is that these tests are really really slow, 20 minutes for 100 tests. So limiting it to 10 tests for now.

Results for the other tests:

  BFT
    simple convergence:                                                     OK (15.24s)
      +++ OK, passed 100 tests.
      
      average #txs/block (100 in total):
      34% R_Btwn (3.0,4.0)
      22% R_Btwn (1.0,2.0)
      21% R_Btwn (2.0,3.0)
      11% R_Btwn (4.0,5.0)
       7% R_Eq 2.0
       3% R_Eq 4.0
       2% R_Eq 0.0

  LeaderSchedule
    simple convergence:                                                     OK (7.43s)
      +++ OK, passed 100 tests.
      
      average #txs/block (100 in total):
      88% R_Btwn (2.0,3.0)
      11% R_Eq 3.0
       1% R_Eq 2.0

  PBFT (note: this is mock)
    simple convergence:                                                     OK (9.78s)
      +++ OK, passed 100 tests.
      
      average #txs/block (100 in total):
      24% R_Btwn (2.0,3.0)
      23% R_Btwn (1.0,2.0)
      18% R_Btwn (3.0,4.0)
      10% R_Eq 4.0
       8% R_Eq 3.0
       7% R_Btwn (4.0,5.0)
       5% R_Eq 2.0
       4% R_Eq 0.0
       1% R_Eq 1.0

  Praos
      +++ OK, passed 100 tests.
      
      average #txs/block (100 in total):
      96% R_Btwn (2.0,3.0)
       3% R_Eq 3.0
       1% R_Eq 2.0
      
  RealPBFT
    simple convergence:                                                     OK (33.24s)
      +++ OK, passed 100 tests.
      
      average #txs/block (100 in total):
      98% R_Eq 0.0
       2% R_Btwn (0.0,1.0)

      involves >=1 re-delegation (100 in total):
      98% False
       2% True

Note that for the RealPBFT case, the blocks contain any transactions at all only when some delegation is happening.

@edsko edsko force-pushed the edsko/generate-byron-txs branch from a0ae123 to 868d318 Compare January 28, 2020 06:42
@edsko edsko requested review from nfrisby and mrBliss and removed request for nfrisby January 28, 2020 06:42
Copy link
Contributor

@mrBliss mrBliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@mrBliss mrBliss added the consensus issues related to ouroboros-consensus label Jan 28, 2020
@edsko
Copy link
Contributor Author

edsko commented Jan 28, 2020

bors r+

@edsko
Copy link
Contributor Author

edsko commented Jan 28, 2020

bors r-

@edsko
Copy link
Contributor Author

edsko commented Jan 28, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Jan 28, 2020
1503: Generate transactions in DualPBFT tests r=edsko a=edsko



Co-authored-by: Edsko de Vries <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 28, 2020

@iohk-bors iohk-bors bot merged commit 868d318 into master Jan 28, 2020
@iohk-bors iohk-bors bot deleted the edsko/generate-byron-txs branch January 28, 2020 14:34
edsko added a commit that referenced this pull request Jan 28, 2020
@edsko
Copy link
Contributor Author

edsko commented Jan 28, 2020

Addressed feedback in #1517 .

iohk-bors bot added a commit that referenced this pull request Jan 28, 2020
1517: Address review feedback on #1503 r=edsko a=edsko



Co-authored-by: Edsko de Vries <[email protected]>
iohk-bors bot added a commit that referenced this pull request Jan 28, 2020
1517: Address review feedback on #1503 r=edsko a=edsko



Co-authored-by: Edsko de Vries <[email protected]>
redxaxder pushed a commit that referenced this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants