-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate transactions in DualPBFT tests #1503
Conversation
80d4b16
to
dc690db
Compare
dc690db
to
0fc26c3
Compare
IntersectMBO/cardano-ledger#1177 should be merged first, but other than that, I think this is mostly ready. We might want to add some labelling to make sure we don't produce non-empty blocks though :) |
890d074
to
a0ae123
Compare
Ok, added the labelling. For the DualPBFT tests we get
The only problem is that these tests are really really slow, 20 minutes for 100 tests. So limiting it to 10 tests for now. Results for the other tests:
Note that for the RealPBFT case, the blocks contain any transactions at all only when some delegation is happening. |
a0ae123
to
868d318
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
bors r+ |
bors r- |
bors r+ |
1503: Generate transactions in DualPBFT tests r=edsko a=edsko Co-authored-by: Edsko de Vries <[email protected]>
Addressed feedback in #1517 . |
1517: Address review feedback on #1503 r=edsko a=edsko Co-authored-by: Edsko de Vries <[email protected]>
1517: Address review feedback on #1503 r=edsko a=edsko Co-authored-by: Edsko de Vries <[email protected]>
No description provided.